Skip to content

Commit

Permalink
Improve blame messages
Browse files Browse the repository at this point in the history
  • Loading branch information
jcs090218 committed Apr 6, 2023
1 parent 22fefb3 commit 4d33437
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions sideline-blame.el
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,18 @@
:type 'string
:group 'sideline-blame)

(defcustom sideline-blame-uncommitted-author-name "Unknown"
(defcustom sideline-blame-uncommitted-author-name
(if (string-empty-p user-full-name) "You"
user-full-name)
"Message for commits where you are author."
:type 'string
:group 'sideline-blame)

(defcustom sideline-blame-uncommitted-time "Now "
"Message for uncommitted timestamp."
:type 'string
:group 'sideline-blame)

(defcustom sideline-blame-uncommitted-message "Uncommitted changes"
"Message for uncommitted lines."
:type 'string
Expand Down Expand Up @@ -111,16 +118,21 @@ Argument COMMAND is required in sideline backend."
(funcall executer
current-file
(funcall vc-msg-get-line-num-function)
(funcall vc-msg-get-version-function))))
(id (plist-get commit-info :id)))
(let* ((uncommitted (zerop (string-to-number id)))
(funcall vc-msg-get-version-function)))))
(let* ((id (plist-get commit-info :id))
(uncommitted (or (null id)
(null (string-match-p "[^0]" id))))
(author (if uncommitted sideline-blame-uncommitted-author-name
(plist-get commit-info :author)))
(time (string-to-number (plist-get commit-info :author-time)))
(time (unless uncommitted
(ignore-errors
(string-to-number (plist-get commit-info :author-time)))))
(summary (if uncommitted sideline-blame-uncommitted-message
(plist-get commit-info :summary))))
(concat (format sideline-blame-author-format author)
(format-time-string sideline-blame-datetime-format time)
(if uncommitted
sideline-blame-uncommitted-time
(format-time-string sideline-blame-datetime-format time))
(format sideline-blame-commit-format summary)))))

(defun sideline-blame--display (callback &rest _)
Expand Down

0 comments on commit 4d33437

Please sign in to comment.