Visual line motions are screen-line motions

[aaronjensen]

Operations like dj do not work as expected when evil-respect-visual-line-mode is t. It deletes to where the j motion would go, rather than deleting the current line and the next line.

This change makes them work, but I do not know what other impact it may have. Any guidance on testing or accomplishing this in another way would be appreciated. Thank you.

[axelf4]

The line type is not right here - will that not make them operate on logical lines? Instead, could you try changing to the screen-line type?

[aaronjensen]

That seems to work too. I don't know the difference between the two. Aren't visual lines logical lines? Or does that mean something else?

[axelf4]

In Emacs terminology a single logical line (terminated by a \n) can be soft-wrapped as several visual lines.¹

Footnotes

1. https://www.gnu.org/software/emacs/manual/html_node/emacs/Visual-Line-Mode.html ↩

[aaronjensen]

Ah, not what I expected "logical" to mean. Thanks. I updated the PR.

[aaronjensen]

@axelf4 does this one look OK? anything else I should update?

[aaronjensen]

@axelf4 friendly reminder on this one. If there's anything I can change on it, let me know. I've been using it now for several months and it's worked just fine.

Thanks.

[aaronjensen]

Hi @tomdl89 would you by chance be able to take a look at this PR and consider merging it? I noticed you were working on related visual line features. I hope you don't mind the mention.

[axelf4]

Looking into it, using screen-line is only correct when evil-respect-visual-line-mode and visual-line-mode are both non-nil, otherwise it behaves like line. An unconditional version of the screen-line type is needed, but screen-line instead of exclusive is still a big improvement. I am not against this PR being merged as-is.

[aaronjensen]

@axelf4 Sounds good.

Could you give an example of problematic behavior when either evil-respect-visual-line-mode or visual-line-mode are disabled?