Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use Eask to test macos and windows #1885

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jcs090218
Copy link
Contributor

Proposed in #1882 (comment).

@jcs090218
Copy link
Contributor Author

See the test result in https://github.com/jcs-PR/evil/actions/runs/8642721884?pr=1.

@tomdl89
Copy link
Member

tomdl89 commented Apr 14, 2024

Thanks for the PR @jcs090218 . I installed Eask locally using npm, and checked out your branch of evil. Running make test succeeds on master, and fails on your branch for me, with this in the terminal:
image
Any idea what Eask is doing differently that might cause this?

@jcs090218
Copy link
Contributor Author

Sorry, the npm version is falling behind the master branch. 😓 I've released a new release 0.9.7. Can you try update to the latest version? Thanks!

@tomdl89
Copy link
Member

tomdl89 commented Apr 15, 2024

Thanks @jcs090218 - that works now. One other thing - can you delete the Cask file (and any other CI-related old stuff) as part of this PR?

@jcs090218
Copy link
Contributor Author

I've deleted the Cask file. But I don't know if there is other CI-related stuff. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants