WIP: CI: enable check for lack of new warnings while byte-compiling #1860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one warning and adds a check that makes sure that CI will fail if a pull-request contains byte-compilation errors. As part of that we replace "emacs-snapshot" in CI with the latest released one because it's "frozen in time", while depending on snapshot may result in CI failing just because upstream introduced new warnings.
This is WIP because: there's one "deprecation warning" which Idk what to do about, because it's internal in Evil. It sounds like:Thoughts? One possible solution is to disable check for "deprecation warnings", but then we will miss new deprecations from upstream.
P.S.: the changes in Makefile also result in a wall of weird messagesMakefile:34: warning: overriding recipe for target 'evil-search.elc'
. I would be very grateful if someone points out how to fix that because I'm not that good in Makefiles (I usually migrate everything I maintain to Ninja or Meson) and Makefiles often behave weirdly.