Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python lockfile creation to new releases #3041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Dec 6, 2022

Dependent on #3038

Per LFAI onboarding, releases need to be reproducible. In addition to the yarn.lock file, the release process will now include a python lockfile (requirements.txt) generated at build time which includes explicit listing direct and indirect dependencies and their hash signatures.

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added component:build build and build related issues(dependencies and docker) status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Dec 6, 2022
@ptitzler ptitzler added this to the 3.14.0 milestone Dec 6, 2022
@akchinSTC akchinSTC removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Dec 9, 2022
@akchinSTC akchinSTC marked this pull request as ready for review December 12, 2022 17:52
@@ -74,3 +74,6 @@ def _get_absolute_path(self, path: str) -> str:
path = path[1:]
absolute_path = os.path.normpath(os.path.join(root_dir, path))
return absolute_path

def write_error(self, status_code, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something flagging these as necessary? Seems like write_error() resolution would be satisfied by the mixin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL is showing warnings for this. seems they want you to explicitly define which method we use despite it always resolving from left to right in terms of inheritance. Guess its for clarity.

@akchinSTC akchinSTC removed this from the 3.14.0 milestone Dec 14, 2022
@akchinSTC akchinSTC linked an issue Dec 14, 2022 that may be closed by this pull request
@akchinSTC akchinSTC force-pushed the lockfile branch 2 times, most recently from 0eb7f0d to 85e9afe Compare December 15, 2022 19:02
@akchinSTC akchinSTC added this to the 4.x Q1 milestone Jan 3, 2023
@ptitzler ptitzler modified the milestones: 4.x Q1, 4.x Q2 Feb 2, 2023
@lresende lresende added status:Needs Discussion status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) status:Needs Discussion status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile cannot compile elyra-python-editor-extension
4 participants