Global read-only and read-only workflows #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmskywalker
requested changes
May 21, 2024
src/modules/Elsa.Workflows.Api/Requirements/ReadOnlyRequirement.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Api/Requirements/ReadOnlyRequirement.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Management/Models/WorkflowDefinitionModel.cs
Outdated
Show resolved
Hide resolved
|
Also please have a look at the Sonar analysis of the PR: |
…adonly Readonly updates to the readonly branch
…ve null resources
…elsa-core into feature/readonly
An unused Protobuf library import was found in Program.cs file. In order to clean up the code and improve readability, this import statement has been removed. No other changes have been made.
Optimize code by removing unnecessary constructor assignments and simplify function calls. The simplification is mainly achieved by directly passing the required services as constructor parameters instead of assigning them to private fields first. This results in a more readable and less redundant code.
sfmskywalker
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented two levels of read-only:
Global read-only that can be set at the engine level by
If enabled, publish, unpublish, delete, create, update references, bulk actions (except export), import, import files are not allowed
Adjusted the existing read-only workflows functionality
If attribute enabled, then publish, retract, delete, import and update references are not allowed.
For both levels, links were exposed to be handled in the designer by leveraging the HATEOAS method.
This change is