Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of installed bin PATH with npm #2291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kachick
Copy link

@kachick kachick commented Dec 25, 2022

Quick Summary: In documents around installation with npm, the installed bin path having a typo.

SSCCE

$ node -v
v18.12.1

$ npm --version
8.19.2

$ npm install [email protected]
...
added 48 packages, and audited 49 packages in 3s
...

$ ./node_modules/bin/elm --version
bash: ./node_modules/bin/elm: No such file or directory

$ ./node_modules/.bin/elm --version
0.19.1
  • Elm: 0.19.1
  • Node.js: 19.3.0, 18.12.1, 14.7.0
  • npm: 9.2.0, 8.19.2
  • Operating System: Linux 5.15.79.1-microsoft-standard-WSL2 #1 SMP Wed Nov 23 01:01:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Additional Details

I found this issue in reading https://www.npmjs.com/package/elm.

@github-actions
Copy link

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant