feat: update poll

[Cl0v1s]

Add an "update poll" option on polls to retrieve the latest results

The refresh icon is animated during loading

[netlify]

✅ Deploy Preview for elk-docs canceled.

Name	Link
🔨 Latest commit	9c8c824
🔍 Latest deploy log	https://app.netlify.com/sites/elk-docs/deploys/67727d13afe8d50008300e78

[netlify]

✅ Deploy Preview for elk-zone ready!

Name	Link
🔨 Latest commit	9c8c824
🔍 Latest deploy log	https://app.netlify.com/sites/elk-zone/deploys/67727d139e555400085855f0
😎 Deploy Preview	https://deploy-preview-3111--elk-zone.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[shuuji3]

Thanks, this is a nice addition.

I checked the change with this preview post: https://deploy-preview-3111--elk-zone.netlify.app/universeodon.com/@elkdev/112190894000305452

One comment: once the poll is finalized, it won't be updated anymore, so should we hide the update button after that?

[Cl0v1s]

That could be great indeed. Do you think it would be better to disabled the button or to hide it completely ?

[shuuji3]

I think hiding it would be better because

1. When the poll has already finished, users won't see the update button so we can avoid making them think it can be updated and they might think there's some issue they cannot click it until they realize the poll was finished at that time.
2. When the poll is still ongoing, users can click the update button to see the latest numbers until it finishes and can know it's finished clearly.

[Cl0v1s]

Will do !

[Cl0v1s]

On second though, there is still the following case: the poll is indeed closed but the local instance did not refetched the results yet (I saw that happening from time to time). Is this a case we should consider ?

[shuuji3]

That sounds a bit tricky. So in my understanding, there are three phases about the poll state and returned poll data:

1. The poll is still ongoing on remote server, and the local server returns the unfinished poll data.
2. The poll was actually finished on remote server, but the local server returns the outdated poll data.
3. The poll was finished and the local server returns the latest finished poll data.

Since Elk can only send request to the local server via masto.js, we can only see the local poll data (possibly outdated) and we can use either expired (boolean) and expiredAt (time to finish) props in Poll (ref. https://neet.github.io/masto.js/interfaces/mastodon.v1.Poll.html) to determine if the poll is finished.

So if we compared expiredAt with the current time and hide the update button, we shows the wrong state for case 2. In this case, Elk shows the poll was finished and hide the update button, but the poll count was not the latest and users cannot update the result anymore.

That means we need to use expired and hide the update button only if its value is true (after local server synced the latest poll data).

Do you think my assumption is correct?

[Cl0v1s]

Oh indeed ! That seems perfectly correct, I will change the code according to that last answer :)