Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): adjust z-index of Embedded Media Player and sticky header #2848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(ui): adjust z-index of Embedded Media Player and sticky header #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/main/MainContent.vue
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ const containerClass = computed(() => {
<template>
<div ref="container" :class="containerClass">
<div
sticky top-0 z10
sticky top-0 z-20
Copy link
Member Author

@shuuji3 shuuji3 Apr 23, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bottom menu has z-20 so I used the same value and set the z-index of media player to z-10:

elk/components/nav/NavBottomMoreMenu.vue

Line 132 in f79d84a

absolute inset-x-0 top-auto bottom-full z-20 h-100vh

pt="[env(safe-area-inset-top,0)]"
bg="[rgba(var(--rgb-bg-base),0.7)]"
class="native:lg:w-[calc(100vw-5rem)] native:xl:w-[calc(135%+(100vw-1200px)/2)]"
Expand Down
2 changes: 1 addition & 1 deletion components/search/SearchWidget.vue
View file
Open in desktop
Expand Up @@ -90,7 +90,7 @@ function activate() {
</button>
</div>
<!-- Results -->
<div left-0 top-11 absolute w-full z10 group-focus-within="pointer-events-auto visible" invisible pointer-events-none>
<div left-0 top-11 absolute w-full z-10 group-focus-within="pointer-events-auto visible" invisible pointer-events-none>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to the fix but all other z-index have the prefix z- so use the same format for better code discoverability.

<div w-full bg-base border="~ base" rounded-3 max-h-100 overflow-auto py2>
<span v-if="query.trim().length === 0" block text-center text-sm text-secondary>
{{ t('search.search_desc') }}
Expand Down
2 changes: 1 addition & 1 deletion components/status/StatusEmbeddedMedia.vue
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ const card = ref(status.card)
absolute
w-full
h-full
z-100
z-10
rounded-lg
style="background: linear-gradient(black, rgba(0,0,0,0.5), transparent, transparent, rgba(0,0,0,0.20))"
>
Expand Down