Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix publish dialog layout #2842

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Apr 22, 2024

fix #2834

The layout is off due to the change during thread implementation. This dialog was not assumed to have multiple widgets either.

Note: This publish dialog can be opened by typing c key.

Before

Screenshot from 2024-04-22 18-22-19
Screenshot from 2024-04-22 18-22-12

After

Screenshot from 2024-04-22 18-21-42

Screenshot from 2024-04-22 18-21-51

Copy link

stackblitz bot commented Apr 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 316e6c1
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/66262c7707a4ce000829a251

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 316e6c1
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66262c77f2610f0008b8b070
😎 Deploy Preview https://deploy-preview-2842--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev
Copy link
Member

I wonder if c should go to the compose screen. I'm not using the shortcut, but even g c opens the dialog.

@patak-dev patak-dev added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 09cae9f Apr 22, 2024
19 checks passed
@patak-dev patak-dev deleted the shuuji3/fix/layout-of-publish-modal branch April 22, 2024 12:56
@shuuji3
Copy link
Member Author

shuuji3 commented Apr 22, 2024

Probably, it is useful when you don't want to lose the current context since if we go to the Compose page, we have to find the original position again.

@patak-dev
Copy link
Member

Maybe c could open the Compose dialog, but g c the compose page 🤔

@shuuji3
Copy link
Member Author

shuuji3 commented Apr 22, 2024

That sounds good. We have g c for the conversation page, but for some issues, c is always prioritized and not working now 😅 (I tried fixing it today but couldn't solve it yet)

// TODO: always overridden by 'c' (compose) shortcut
whenever(logicAnd(isAuthenticated, notUsingInput, useMagicSequence(['g', 'c'])), () => navigateTo('/conversations'))

I think when we fix this issue, we can use g c for the compose page and assign another key for the conversation page. Perhaps, we can use g d (direct) or g m (message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread layout is off in compose dialog
2 participants