Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre tag overwritten by default style #2699

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Mar 18, 2024

fix #2590
Ensure the pre tag style is not overwritten by the user agent stylesheet. The default value was set to pre.

Copy link

stackblitz bot commented Mar 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 32d390f
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65f7ace8f793a3000893d0f8

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 32d390f
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65f7ace8d7481e0008b1e5ff
😎 Deploy Preview https://deploy-preview-2699--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I can confirm that the pre-wrap is now correctly applied in the same way as the editor dialog on both the timeline and the status pages.

Before

Screenshot from 2024-03-18 18-04-58

After

Screenshot from 2024-03-18 18-05-43

Mastodon UI (for reference)

Screenshot from 2024-03-18 17-49-35

Mobile

Edit

Screenshot from 2024-03-18 15-23-55

Before

Screenshot from 2024-03-18 15-23-28

After

Screenshot from 2024-03-18 18-20-56

@shuuji3
Copy link
Member

shuuji3 commented Mar 18, 2024

By the way, I noticed that the syntax color is not applied on the initial load. But this is a separate issue so I will file it as another Issue. (filed as #2700)

@patak-dev patak-dev added this pull request to the merge queue Mar 18, 2024
Merged via the queue into elk-zone:main with commit c89e499 Mar 18, 2024
13 checks passed
@Sma11X Sma11X deleted the fix/pre-tag-style branch March 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code wrapping mismatch between edit and view
3 participants