fix(ui): adjust z-index of Embedded Media Player and sticky header #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
commented
Apr 23, 2024
| @@ -27,7 +27,7 @@ const containerClass = computed(() => { | |||
| <template> | |||
| <div ref="container" :class="containerClass"> | |||
| <div | |||
| sticky top-0 z10 | |||
| sticky top-0 z-20 | |||
There was a problem hiding this comment.
The bottom menu has z-20 so I used the same value and set the z-index of media player to z-10:
elk/components/nav/NavBottomMoreMenu.vue
Line 132 in f79d84a
| @@ -90,7 +90,7 @@ function activate() { | |||
| </button> | |||
| </div> | |||
| <!-- Results --> | |||
| <div left-0 top-11 absolute w-full z10 group-focus-within="pointer-events-auto visible" invisible pointer-events-none> | |||
| <div left-0 top-11 absolute w-full z-10 group-focus-within="pointer-events-auto visible" invisible pointer-events-none> | |||
There was a problem hiding this comment.
This is not related to the fix but all other z-index have the prefix z- so use the same format for better code discoverability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2847 by adjusting z-index values
After fix