You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I can see we might have situations like this throughout the app. Maybe a feature we can toggle on in the tauri module that forces the elk.zone hostname so we don't have to reference tauri here?
@danielroe Because it's just a browser behavior, and Tauri has no control over it. I guess the only thing we could do is to monkey patch location.origin in the native bundle so that it always returns elk.zone but I'm not a fan of that solution.
I understand the need and agree. I'm suggesting that rather than check the environment variable here, we instead have a global setting (maybe in app config) that changes behaviour across everywhere in the app that accesses location.origin.
Edit: I see it's just here and in login that it matters, and we probably shouldn't change that one. I still think a global setting works better. Happy to update within this PR if you don't mind me pushing to it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
piotrski
force-pushed
the
fix/native-link-url
branch
from
This should fix elk-zone/elk-native/issues/37