Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extends instead of git submodule setup #65

Open
danielroe opened this issue Jan 29, 2023 · 1 comment
Open

Use extends instead of git submodule setup #65

danielroe opened this issue Jan 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@danielroe
Copy link
Member

Currently we use git submodules to check out https://github.com/elk-zone/elk. This means our options for customising elk for native build are more limited and often have to happen upstream, which can hold back development of elk-native.

Instead, I propose we use the Nuxt extends/layers feature (issue tracker) to build on top of existing elk app.

This will allow us to move the tauri module that currently exists upstream into this rep and address issues like elk-zone/elk#1492 more easily.

@danielroe danielroe added the enhancement New feature or request label Jan 29, 2023
@danielroe danielroe self-assigned this Jan 29, 2023
@jbolda
Copy link

jbolda commented Jan 29, 2023

Does that mean that this repo would consume elk as a npm (registry) dependency? We would have a minimal Nuxt setup and extend the elk-zone/elk dependency.

Or are you thinking monorepo with shared code and layers to customize the remaining bits that are specifically web only vs app only?

Either way, I would personally prefer moving away from submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants