[IEx][Autocomplete] Fix crashing on autocompleting structs #14150
Conversation
|
Can you please try adding a test as well on |
| @@ -440,6 +440,19 @@ defmodule IEx.AutocompleteTest do | |||
| assert {:yes, ~c"ry: ", []} = expand(~c"%URI{var | path: \"foo\", que") | |||
| assert {:no, [], []} = expand(~c"%URI{var | path: \"foo\", unkno") | |||
| assert {:no, [], []} = expand(~c"%Unknown{var | path: \"foo\", unkno") | |||
|
|
|||
| eval("var = %URI{}") | |||
There was a problem hiding this comment.
Shouldn't we add a test for an exception struct (e.g. ArgumentError) as well?
There was a problem hiding this comment.
@lukaszsamson this is tricky because how do we know which keys to skip? You likely want to skip the meta key in Ecto schemas too and so on. So I'd prefer to provide a general mechanism to control this (perhaps with the type system) instead of special casing __exception__.
There was a problem hiding this comment.
Sure. Either we filter out all underscored fields or let the library decide in some way what is internal. My concern was more if __exception__ needs some special handling the way __struct__ does.
|
💚 💙 💜 💛 ❤️ |
Fixes the behaviour of autocompleting map update with structures described in issue #14149
Autocompleting the last line now works properly