-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply typography suggestions #1339
Conversation
These are discussed changes from our monthly UX meetings |
@bedroesb was there a preview of these changes? Perhaps they been applied to the toolkit theme: https://elixir-belgium.github.io/elixir-toolkit-theme/? |
definitely possible, the problem is a bit that we use font weights that are not always available with the fonts used by people... |
@martin-nc for example with the IDTk for me the jump is to big: But this is just my opinion... |
Maybe I just have to get used to it :) |
Hmmm - I hadn't thought about people choosing different fonts for the toolkit theme. If that's the case, you might want to stick to 400 and 700 for that theme, and keep it simple. Each font should definitely have those! Unless it's a display or monospace font, of course, but you can't account for that. So then the questions is: do we stick to the same rules for the RDMkit? I don't think that's necessary. Once the theme is out there it's a free-for-all, and you can't enforce a law about how people should use fonts in it. For the RDMkit, I'd maybe make the |
@martin-nc I agree, I changed them to 600! I was thinking of merging these changes for now and doing rethinking the theme on its own another time 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
H1 updates
H2 updates
500600H3