Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure pages on Human data and GDPR compliance #1264

Merged
merged 22 commits into from
Sep 1, 2023
Merged

Restructure pages on Human data and GDPR compliance #1264

merged 22 commits into from
Sep 1, 2023

Conversation

vildead
Copy link
Contributor

@vildead vildead commented May 24, 2023

No description provided.

@vildead vildead force-pushed the restructure-pages-on-human-data branch from 7fbd76a to c0d4584 Compare May 24, 2023 08:25
@Nazeeefa Nazeeefa added the contentathon Contentathon related issues and PRs label May 24, 2023
@vildead vildead mentioned this pull request May 24, 2023
Closed
@nicjar nicjar mentioned this pull request May 24, 2023
Open
bedroesb
bedroesb reviewed Jun 15, 2023
View reviewed changes
pages/your_tasks/data_security.md Outdated
uuid: 49c009cb-a38c-4836-9780-8a8b3dd1cbac
- name: Do you need a Data Protection Impact Assessment?
uuid: 8915bd25-db22-4ed6-bcc8-b1bbdc52989e
- name: Is the risk of information loss, leaks and vandalism acceptably low?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these DSW links coming from? Because the knowledge model needs to be updated for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the Life Sciences DSW Knowledge Model 2.4.4

Do you know where I can submit a MR for this change? https://rdmkit.elixir-europe.org/page_metadata does not say

_data/tool_and_resource_list.yml Outdated Show resolved Hide resolved
@bedroesb
Copy link
Member

@vildead We recently for the restructuring of the Your role pages added a redirect, so I guess we can apply the same here to!

@bedroesb
Copy link
Member

I redid the renaming of the file + added a redirect + did the same for data sensitivity. Let me know if what I did was correct :)

bedroesb
bedroesb reviewed Aug 22, 2023
View reviewed changes
pages/your_tasks/data_security.md
@@ -18,12 +19,14 @@ dsw:
the data?
uuid: a30f5047-33c1-45a7-8b3f-b1b90c364fc9
faircookbook:
- name: Licensing Data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faircookbook changes need to be applied to this file: https://github.com/elixir-europe/faircookbook-rdmkit/blob/main/faircookbook_rdmkit_mapping.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are prepared here: elixir-europe/faircookbook-rdmkit#41

@bedroesb bedroesb linked an issue Aug 22, 2023 that may be closed by this pull request
Pages on compliance #1270
Closed
@bedroesb
Copy link
Member

Not sure if this latest issue is actually related!

@bedroesb
Copy link
Member

Important will be to update DSW and FCB accordingly!

vildead added a commit to vildead/faircookbook-rdmkit that referenced this pull request Aug 23, 2023
@vildead
reflect changes of human data pages elixir-europe/rdmkit#1264
3c30079
@vildead vildead mentioned this pull request Aug 23, 2023
Merged
@bedroesb
Copy link
Member

@vildead this is great. 💪 Sadly I still don't know what to procedure is to update the DSW knowledge model...

@bedroesb
Copy link
Member

I think the procedure is to contact @rwwh @MarekSuchanek or @janslifka to request changes to the Life Sciences knowledge model :)

To make their life easier, could you make an easy to read list of which questions have to be linked to which (new) RDMkit page? @vildead

@bedroesb
Copy link
Member

the RDMkit pages will get updated automatically accordingly

@bedroesb
Copy link
Member

@vildead What do you think needs to be done before this page can set as "Ready for review" ?

@vildead
Copy link
Contributor Author

vildead commented Aug 28, 2023

@vildead What do you think needs to be done before this page can set as "Ready for review" ?

I am in contact with Rob about the update of links in DSW. I can cross post here as well:

A) Following questions should point to gdpr_compliance (not to data_protection):
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=49c009cb-a38c-4836-9780-8a8b3dd1cbac
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=8915bd25-db22-4ed6-bcc8-b1bbdc52989e
B) Following question should point to data_security (not to data_protection):
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=a30f5047-33c1-45a7-8b3f-b1b90c364fc9
C) Following questions should point to data_sensitivity (not to sensitive_data):
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=019db0b3-9067-4134-8bfd-76db3cfc572a
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=49c009cb-a38c-4836-9780-8a8b3dd1cbac
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=59748a7b-f729-404d-babe-3147e2c6b247
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=6b3d62a5-1d4d-49e1-aaf1-0a8b398a7ac3
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=a1d76760-053c-4706-80a2-cfb6c6a061f3
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=cc95b399-7d8d-4232-bccf-686f78c91bff
https://researchers.ds-wizard.org/knowledge-models/dsw:root:latest/preview?questionUuid=d5990471-0618-42cd-92cb-bbbfd4f61532

B) and C) are kind of optional as the redirection is anyway in place.

@bedroesb you say the links to DSW in the header of the files (e.g. here) update automatically? So I dont have to update the header?

@bedroesb
Copy link
Member

@vildead correct! I let the github actions run after merge so they get updated

1 similar comment
@bedroesb
Copy link
Member

@vildead correct! I let the github actions run after merge so they get updated

@rwwh
Copy link
Contributor

rwwh commented Aug 29, 2023

CC @MarekSuchanek for releasing this in synchrony with the KM in DS Wizard; the changes have been made in 2.6.3.

@vildead vildead marked this pull request as ready for review August 29, 2023 12:20
@bianchini88
Update gdpr_compliance.md
9c65f07 
Minor grammar/spelling improvements
@bedroesb
Copy link
Member

@vildead the title implies that you would also change the human data page, is this by any chance related to this issue? #1274

@bedroesb bedroesb merged commit db80c51 into elixir-europe:master Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedroesb bedroesb bedroesb left review comments

@floradanna floradanna floradanna approved these changes

@bianchini88 bianchini88 bianchini88 approved these changes

@lauportell lauportell Awaiting requested review from lauportell lauportell is a code owner

@Nazeeefa Nazeeefa Awaiting requested review from Nazeeefa Nazeeefa is a code owner

@DanFaria DanFaria Awaiting requested review from DanFaria

@pinarpink pinarpink Awaiting requested review from pinarpink

@korbinib korbinib Awaiting requested review from korbinib korbinib is a code owner

@wittigue wittigue Awaiting requested review from wittigue wittigue is a code owner

@smza smza Awaiting requested review from smza smza is a code owner

Assignees
No one assigned
Labels
contentathon Contentathon related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pages on compliance
6 participants
@vildead @bedroesb @rwwh @floradanna @bianchini88 @Nazeeefa