Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new showcase page for KGG #339

Merged
merged 13 commits into from
Sep 5, 2024
Merged

Create new showcase page for KGG #339

merged 13 commits into from
Sep 5, 2024

Conversation

lauportell
Copy link
Contributor

@lauportell lauportell commented Aug 13, 2024

Closes #338

@bedroesb
Copy link
Member

bedroesb commented Sep 2, 2024

@lauportell the only thing I wodner here. also @rabuono, is whether we want to keep "Knowledge Graph Generator (KGG) - A fully automated workflow for creating disease-specific KGs" as a page title. It is ratehr long and for the sidebar I choose only "Knowledge Graph Generator (KGG)".

Besides that I am happy to approve this. I resolved all issues I think

Copy link
Contributor

@jrkarki jrkarki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Fraunhofer logo with name ITMP should be used instead of IESE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frauenhofer_ITMP

Sorry, the institute name is not correct. PFA our institute logo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrkarki could you provide the logo in svg and cropped like the one I found on the internet? The one you rpovided now has lots of spacing which makes it look off on the page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frauenhofer_ITMP_logo

Better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks ok:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. How long will it take to appear here -> https://www.infectious-diseases-toolkit.org/showcase/ ?

@bedroesb bedroesb merged commit 0dbede7 into main Sep 5, 2024
6 checks passed
@bedroesb bedroesb deleted the showcase_kgg branch September 5, 2024 11:49
@bedroesb
Copy link
Member

bedroesb commented Sep 5, 2024

@jrkarki it is live: https://www.infectious-diseases-toolkit.org/showcase/knowledge-graph-generator Thanks for your contribution! The only thing I now notice is that the tool itself is not added to our toolstable,would you be willing to do this?https://www.infectious-diseases-toolkit.org/contribute/tool-resource-update

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New showcase page on KGG
3 participants