Add -Wno-psabi on gcc to remove bogus warnings on ppc

eliaskosunen · Oct 27, 2023 · 0314fa2 · 0314fa2
1 parent f5f394a
commit 0314fa2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -85,7 +85,7 @@ jobs:
           # gcc 12 isn't available on 20.04 (11 and 13 are in ubuntu-toolchain-r)
           - cxx: g++-12
             os: 20.04
-          # simdutf has problems with clang 6 and 7 (_ktestc_mask64_u8 undefined)
+          # FIXME?: simdutf has problems with clang 6 and 7 (_ktestc_mask64_u8 undefined)
           - cxx: clang++-7
           - cxx: clang++-6.0
           # FIXME: Locally unreproducible ICE
@@ -94,6 +94,13 @@ jobs:
           - cxx: g++-11
             std: 20
             os: 20.04
+          # FIXME?: weird incompatibility with libstdc++ 13 inside <chrono>
+          - cxx: clang++-14
+            std: 20
+            os: 22.04
+          - cxx: clang++-13
+            std: 20
+            os: 22.04
 
     steps:
       - uses: actions/checkout@v3

diff --git a/cmake/buildflags.cmake b/cmake/buildflags.cmake
@@ -15,6 +15,7 @@ function(get_gcc_warning_flags flags)
             -Wctor-dtor-privacy -Wdisabled-optimization
             -Winvalid-pch -Wnoexcept
             -Wmissing-declarations -Woverloaded-virtual
+            -Wno-psabi
             $<$<VERSION_GREATER_EQUAL:CXX_COMPILER_VERSION,5.0>:
             -Wdouble-promotion -Wtrampolines
             -Wzero-as-null-pointer-constant

diff --git a/cmake/dependencies.cmake b/cmake/dependencies.cmake
@@ -36,6 +36,7 @@ if (SCN_TESTS)
             )
     target_link_libraries(scn_gtest PRIVATE Threads::Threads)
     target_compile_features(scn_gtest PUBLIC cxx_std_14)
+    target_compile_options(scn_gtest PRIVATE $<$<CXX_COMPILER_ID:GNU>: -Wno-psabi>)
 endif()
 
 if (SCN_BENCHMARKS)