Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Inject TYPO3's client into sub-command #478

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eliashaeussler
Copy link
Owner

This PR now passes TYPO3's client to the underlying sub-command when running the warming:cachewarmup command. This assures that globally configured HTTP options are used.

@eliashaeussler eliashaeussler added the bug Something isn't working label Oct 10, 2023
@eliashaeussler eliashaeussler self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c2b67ab) 21.52% compared to head (9c084c9) 21.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##              0.5.x     #478      +/-   ##
============================================
- Coverage     21.52%   21.45%   -0.07%     
- Complexity      295      296       +1     
============================================
  Files            27       27              
  Lines           920      923       +3     
============================================
  Hits            198      198              
- Misses          722      725       +3     
Files Coverage Δ
Classes/Command/WarmupCommand.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliashaeussler eliashaeussler merged commit 36bad75 into 0.5.x Oct 10, 2023
13 of 15 checks passed
@eliashaeussler eliashaeussler deleted the fix/0.5/typo3-client branch October 10, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant