Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inkscape's Zoom #915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Fatih20
Copy link
Contributor

@Fatih20 Fatih20 commented Jul 11, 2020

Continues upon #467

This is how the icons look under elementary's light theme
image
This is how the icons look under elementary's dark theme
image

@cassidyjames
Copy link
Contributor

Is there a reason we're not symlinking to an existing zoom icon? I am also concerned about the similarities between zoom and search here.

@Fatih20
Copy link
Contributor Author

Fatih20 commented Aug 5, 2020

Is there a reason we're not symlinking to an existing zoom icon? I am also concerned about the similarities between zoom and search here.

Is there any other zoom icon other than the one with white square? Sorry if I'm not being thorough.
I was basing my design in the context of Inkscape. Which, because of the icon placement probably wouldn't be mistaken for search. However, I think zoom is already synonymous with magnifying glasses (unfortunately, so does search which created the problem you've pointed out), that making the design something else would be weird, no?

@jeremypw
Copy link

@cassidyjames This review seems to have stalled - should it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants