only re-add svg files which were already added #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in pre-commit, only re-add svg files which were already added to prevent wrong files to be committed unintentionally The pre-commit hook used to automatically vacuum SVGs changes files, thus they have to be added again. This was done using `git add .` before. However, this can be considered hazardous, because it adds all files, tracked and untracked, added or not, to the commit, as the contributor might have experimented around leaving various files. This change tries to minimize that risk by only considering files already marked for commit (but not files which are "only" tracked) and whose names also end in `.svg`.
|
also, we can skip vacuuming and speed up committing when no SVG is to be committed |
|
@danrabbit: Has no recent activity. Does this need closing or converting to draft? I do not have the necessary rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in pre-commit, only re-add svg files which were already added to prevent wrong files to be committed unintentionally
The pre-commit hook used to automatically vacuum SVGs changes files, thus they have to be added again. This was done using
git add .before. However, this can be considered hazardous, because it adds all files, tracked and untracked, added or not, to the commit, as the contributor might have experimented around leaving various files.This change tries to minimize that risk by only considering files already marked for commit (but not files which are "only" tracked) and whose names also end in
.svg.