Expose restore tabs on startup option #2343
Conversation
|
@danirabbit Is this viable from a UX point of view? |
src/View/Widgets/AppMenu.vala
Outdated
| action_name = "win.folders-before-files" | ||
| }; | ||
|
|
||
| var restore_tabs = new Granite.SwitchModelButton (_("Restore Tabs on Starting")) { |
There was a problem hiding this comment.
Not sure if this wording is best? When I see "start-up" I think more the machine/OS starting up. I am almost tempted to keep it layman and suggest "Restore Tabs from Last Time" but I am not totally convinced that is a good alternative lol
There was a problem hiding this comment.
How about "Restore Tabs when Launching". Could also include a TRANSLATORS comment to clarify.
There was a problem hiding this comment.
I feel like "when Launching" might be too ambiguous.
Web calls this "Restore Tabs on Startup" which would we could go with for consistency
Chrome calls it "Continue where you left off" which feels super ambiguous 😬
Firefox calls this "Show Tabs from Last Time" which I think validates @zeebok here and might be the most clear
There was a problem hiding this comment.
OK, I'll go with @zeebok 's suggestion then.
|
Seems like checks failing due to this compile error:
|
|
It seems to be a mismatch between the vapi and library version. glib added a wrapper function to the printerr_literal vfunc in 2.80. but the vfunc is older. |
|
@Marukesu Thanks for the info. Can it be changed back to |
|
Yes, there is no harm in changing it to cmd.printerr(). |
At the moment the only way to turn off restoring tabs in Files without turning of History for all apps in the System Settings is to edit the gsettings using either
dconf-editoror the CLI, which is non-obvious.This PR adds another switch to the AppMenu to toggle this setting. This is also useful for allowing non-technical users to workaround/diagnose some issues (see #2342 (comment))