New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filemanager1 scroll to item #2280
base: main
Are you sure you want to change the base?
Conversation
Needs further testing following change to async adding tabs. |
# Conflicts fixed: # src/View/Window.vala
There is some uncertainty about when Files should create duplicate a tab when the requested folder is already showing (has been restored). At the moment duplicates are created on startup but not if Files is already running. |
The code itself looks fine to me. I can try to fit in time to test this over the weekend, but if you feel you tested enough already I don't mind approving |
I am testing on eOS7:
Both seem to always open a new tab, but it does scroll to the correct file with it already selected. Is it creating the tab before restoring or something?
This behaves as expected. Creates a tab if needed or switches to an existing one of the correct directory with desired file selected
Works as expected I think. Only situation of note is that if Files is closed, Open in will open a new tab even if the correct folder is a restored tab. (ie Downloads/ tab will be restored and a new Downloads/ tab will open from the browser) similar to the issue I saw from terminal.
This looks to work alright |
Fixes #2214
In order to make the behaviour that expected and the same regardless of whether Files is already running or not when the request is made it was necessary to fix several problems, in particular some races occurring when Files was starting up.
To test:
Call Files from the command line with a non-directory file parameter that is a child of one of the tabs that is restored on startup, on that contains a lot of files and requires scrolling to view the requested child.
Do similar where requested tab is not restored.
Do similar when Files is already running and is/is not showing the requested tab.
Use "Open in Folder" function of browser or other app with similar function.
In each case Files should show the requested item selected and visible.
Check for regressions where the requested item is a folder. The requested folder should open in a new tab if it is not already open, even if it is a child of an existing tab.