Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compile #2225

Draft
wants to merge 109 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
759849e
Start to change or comment out code that does not compile (incomplete)
jeremypw Aug 31, 2022
487830b
Second commit towards making compilable
jeremypw Aug 31, 2022
0b78503
Libcore, data, pantheon-files-daemon, plugins, po compilable
jeremypw Aug 31, 2022
8219853
Partway through making FileChooser portal compilable
jeremypw Aug 31, 2022
0aa024b
Libcore and portal now compile
jeremypw Sep 3, 2022
ca8c3b3
Make some src classes compilable
jeremypw Sep 3, 2022
7612ce2
Partial work on /src
jeremypw Sep 3, 2022
61ca499
More work on src classes
jeremypw Sep 3, 2022
20126bf
More work
jeremypw Sep 4, 2022
0a76731
More work on Window
jeremypw Sep 4, 2022
8a02f72
Work on Sidebar
jeremypw Sep 4, 2022
2a8d1fd
More work on Sidebar
jeremypw Sep 4, 2022
5e24814
More work on AbstractDirectoryView menus
jeremypw Sep 4, 2022
13f3ccb
More work on AbstractDirectoryView
jeremypw Sep 4, 2022
b34efc2
Work on Renderers and other classes
jeremypw Sep 5, 2022
7c2284f
Work on TextRenderer and editables
jeremypw Sep 5, 2022
5ce74b5
More work on PropertiesDIalog
jeremypw Sep 5, 2022
e911a8b
Mork work on header, window
jeremypw Sep 6, 2022
78d53d2
Work on Editable labels
jeremypw Sep 6, 2022
4c41798
Avoid subclass some sealed classes/structs in DirectoryView
jeremypw Sep 6, 2022
e885a72
Avoid subclassing Gtk.Label in properties widgets
jeremypw Sep 6, 2022
f7e00e6
Avoid subclassing sealed class in Sidebar
jeremypw Sep 6, 2022
be0ce20
First compilable lint-free version
jeremypw Sep 6, 2022
9fb9e79
Fix portal dependencies
jeremypw Jun 30, 2023
73a2f2e
Fix DnDHandler syntax
jeremypw Jun 30, 2023
8374811
Replace missing Gtk constant string
jeremypw Jun 30, 2023
200eedf
Port BulkRenamer EditWidget
jeremypw Jun 30, 2023
abb396e
Fix or comment out RenamerDialog
jeremypw Jun 30, 2023
7479368
Consequential fix to AbstractDirectoryView
jeremypw Jun 30, 2023
3dcf828
Window: Update local thumbnail action
jeremypw Jun 30, 2023
633d2a1
Fix listbox child iteration
jeremypw Jun 30, 2023
59d5b65
Fix or comment out RenamerListBox
jeremypw Jun 30, 2023
7cbda83
Fix or comment out RenamerModifier
jeremypw Jun 30, 2023
c4a5e42
Window: Fix check_for_tabs_with_same_name
jeremypw Jun 30, 2023
9796fc6
AbstractTreeView: Remove duplicate declaration
jeremypw Jun 30, 2023
b1973f8
Minor corrections
jeremypw Jun 30, 2023
f97c80e
VolumeRow: Comment out Gtk.MenuItem
jeremypw Jun 30, 2023
c3821a0
RenamerListBox: Do not subclass Gtk.ListBox
jeremypw Jun 30, 2023
b4cce89
Fix lint
jeremypw Jun 30, 2023
50d5b2b
Comment out failing test
jeremypw Jun 30, 2023
ccb4d7f
Update main.yml
jeremypw Jun 30, 2023
8a6f387
Lose libhandy
jeremypw Jun 30, 2023
ddd0db7
Update README.md
jeremypw Jun 30, 2023
565b124
Use Gtk.HeaderBar
jeremypw Jun 30, 2023
69906d7
Update filechooser-portal/FileChooserDialog.vala
jeremypw Jun 30, 2023
988fbbd
Use Gtk.HeaderBar in FileChooserDialog
jeremypw Jun 30, 2023
6434c0d
Apply suggestions from code review
jeremypw Jun 30, 2023
39f1688
ConnectServerDialog: Fix set_default_widget
jeremypw Jun 30, 2023
9f57498
FileCHooserDialog: Specify pixel_size
jeremypw Jun 30, 2023
45fec7a
Revert incorrect property `pixel_size` - use css class
jeremypw Jun 30, 2023
aa7be9f
ConnectServerDialog: connecting_grid -> connecting_box
jeremypw Jun 30, 2023
73ae74f
Update libcore/FileConflictDialog.vala
jeremypw Jun 30, 2023
6e96a14
FileConflictDialog: expander_grid -> expander_box
jeremypw Jun 30, 2023
aa99f03
ConnectServerDialog: Subclass Gtk.Window
jeremypw Jun 30, 2023
f1cebbc
Update libcore/FileConflictDialog.vala
jeremypw Jun 30, 2023
b789b6e
Merge branch 'main' into make-compile
jeremypw Jun 30, 2023
4064826
ConnectServerDialog: add -> append after merging master
jeremypw Jun 30, 2023
26e74f0
Update libcore/AbstractSlot.vala
jeremypw Jun 30, 2023
072387e
Update libcore/ConnectServerDialog.vala
jeremypw Jun 30, 2023
5543c01
Translated using Weblate (Ukrainian)
IhorHordiichuk Jun 29, 2023
6b622d2
Translated using Weblate (Japanese)
ryonakano Jun 28, 2023
f86e5a4
Translated using Weblate (Catalan)
Jun 29, 2023
75153ae
Translated using Weblate (English (United Kingdom))
davidmhewitt Jun 29, 2023
209a52c
Translated using Weblate (Hebrew)
yarons Jun 28, 2023
b3350af
Translated using Weblate (Hungarian)
TomiOhl Jun 29, 2023
dd93944
Translated using Weblate (Russian)
lenemter Jun 28, 2023
5212b57
ConnectServerDialog: fix missing window contents and dialog style (#2…
danirabbit Jun 30, 2023
916af09
ViewSwitcher: fix behavior, don't use observe (#2229)
danirabbit Jul 2, 2023
1be5c02
Update libcore/FileOperations/DialogUtils.vala
jeremypw Jul 2, 2023
06c15a7
Update libcore/FileOperations/CommonJob.vala
jeremypw Jul 2, 2023
9553c9c
Update libcore/FileOperations/DialogUtils.vala
jeremypw Jul 2, 2023
6d5a38b
Update libcore/FileOperations/DialogUtils.vala
jeremypw Jul 2, 2023
d966921
Update libcore/FileOperations/DialogUtils.vala
jeremypw Jul 2, 2023
2c6c9c0
Update libcore/FileOperations/EmptyTrashJob.vala
jeremypw Jul 2, 2023
42135a3
Update libcore/FileOperations/EmptyTrashJob.vala
jeremypw Jul 2, 2023
534706d
Update meson.build
jeremypw Jul 2, 2023
84ae0a2
Update src/View/Sidebar/AbstractMountableRow.vala
jeremypw Jul 2, 2023
54ac427
Update src/Dialogs/BulkRenamer/RenamerModifier.vala
jeremypw Jul 2, 2023
44d0adb
Update src/ProgressUIHandler.vala
jeremypw Jul 2, 2023
3bc34a3
Update src/View/Sidebar/AbstractMountableRow.vala
jeremypw Jul 2, 2023
e9fa070
Update src/View/Widgets/PermissionButton.vala
jeremypw Jul 2, 2023
0e40645
Update src/Dialogs/BulkRenamer/RenamerModifier.vala
jeremypw Jul 2, 2023
3c90124
BookmarkRow: Revert Box to Grid
jeremypw Jul 2, 2023
954dffb
merge main
danirabbit Jul 3, 2023
f310bc1
ViewSwitcher: use icon_name property
danirabbit Jul 3, 2023
9a137d7
Lose commented out code
jeremypw Jul 4, 2023
8d490b8
VolumePropertiesWindow: Remove commented out code
jeremypw Jul 4, 2023
18ebd1b
Update src/Dialogs/BulkRenamer/RenamerDialog.vala
jeremypw Jul 4, 2023
ca92586
Merge main
danirabbit Jul 11, 2023
cb13d69
Fix window decoration
danirabbit Jul 11, 2023
7dcf588
merge main
danirabbit Jul 12, 2023
fab8060
merge main
danirabbit Jul 12, 2023
a7f23a5
Remove extra class
danirabbit Jul 12, 2023
ee99666
Merge main
danirabbit Jul 12, 2023
96494ae
fix sidebar resizing
danirabbit Jul 12, 2023
ec686e7
merge main
danirabbit Jul 12, 2023
3331112
merge main
danirabbit Jul 13, 2023
c19d507
merge main
danirabbit Jul 15, 2023
eccdd0c
Minor codestyle
danirabbit Jul 15, 2023
2c6786b
merge main
danirabbit Jul 19, 2023
067830c
Merge main
danirabbit Jul 19, 2023
0ccdc3b
Fix merge issues
danirabbit Jul 19, 2023
dfcac0c
Remove unncessary comment
danirabbit Jul 19, 2023
29fcd54
Update ProgressInfoWidget.vala
danirabbit Aug 13, 2023
e50dc2c
Merge main
danirabbit Aug 14, 2023
2474a53
fix lint
danirabbit Aug 14, 2023
e67cbca
remove extra comment
danirabbit Aug 14, 2023
a76ae8e
Merge main
danirabbit Aug 24, 2023
d297a87
merge master
danirabbit Jan 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ jobs:
- name: Install Dependencies
run: |
apt update
apt install -y libgala-dev libgee-0.8-dev libglib2.0-dev libgranite-dev libgtk-3-dev libhandy-1-dev libcanberra-dev
apt install -y libcloudproviders-dev libdbus-glib-1-dev libnotify-dev libpango1.0-dev libplank-dev
apt install -y libsqlite3-dev libunity-dev libzeitgeist-2.0-dev policykit-1 libgit2-glib-1.0-dev
apt install -y libgala-dev libgee-0.8-dev libglib2.0-dev libgranite-7-dev libgtk-4-dev libadwaita-1-dev libcanberra-dev libsqlite3-dev
apt install -y meson valac
- name: Build
env:
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ You'll need the following dependencies:
* libgee-0.8-dev
* libgit2-glib-1.0-dev
* libglib2.0-dev
* libgranite-dev >= 6.1.0
* libgtk-3-dev
* libhandy-1-dev >= 0.83.0
* libgranite-7-dev
* libgtk-4-dev
* libadwaita-1-dev
* libnotify-dev
* libpango1.0-dev
* libplank-dev
Expand Down
24 changes: 15 additions & 9 deletions filechooser-portal/ExternalWindow.vala
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*/

public interface ExternalWindow : GLib.Object {
public abstract void set_parent_of (Gdk.Window child_window);
public abstract void set_parent_of (Gdk.Surface child_window);

public static ExternalWindow? from_handle (string handle) {
const string X11_PREFIX = "x11:";
Expand Down Expand Up @@ -52,7 +52,7 @@ public interface ExternalWindow : GLib.Object {
public class ExternalWindowX11 : ExternalWindow, GLib.Object {
private static Gdk.Display? x11_display = null;

private Gdk.Window foreign_gdk_window;
private Gdk.Surface foreign_gdk_window;

public ExternalWindowX11 (string handle) throws GLib.IOError {
var display = get_x11_display ();
Expand All @@ -62,12 +62,12 @@ public class ExternalWindowX11 : ExternalWindow, GLib.Object {

int xid;
if (!int.try_parse (handle, out xid, null, 16)) {
throw new IOError.FAILED ("Failed to reference external X11 window, invalid XID %s", handle);
throw new IOError.FAILED ("Failed to reference external X11 surface, invalid XID %s", handle);
}

foreign_gdk_window = new Gdk.X11.Window.foreign_for_display ((Gdk.X11.Display)display, xid);
foreign_gdk_window = Gdk.X11.Surface.lookup_for_display ((Gdk.X11.Display)display, xid);
if (foreign_gdk_window == null) {
throw new IOError.FAILED ("Failed to create foreign window for XID %d", xid);
throw new IOError.FAILED ("Failed to create X11 Surface for XID %d", xid);
}
}

Expand All @@ -77,7 +77,9 @@ public class ExternalWindowX11 : ExternalWindow, GLib.Object {
}

Gdk.set_allowed_backends ("x11");
//FIXME This should not have a null parameter
x11_display = Gdk.Display.open (null);
//FIXME This should not have a null parameter
Gdk.set_allowed_backends (null);

if (x11_display == null) {
Expand All @@ -87,8 +89,10 @@ public class ExternalWindowX11 : ExternalWindow, GLib.Object {
return x11_display;
}

public void set_parent_of (Gdk.Window child_window) {
child_window.set_transient_for (foreign_gdk_window);
public void set_parent_of (Gdk.Surface child_window) {
if (child_window is Gdk.Toplevel) {
((Gdk.Toplevel)child_window).set_transient_for (foreign_gdk_window);
}
}
}

Expand All @@ -112,7 +116,9 @@ public class ExternalWindowWayland : ExternalWindow, GLib.Object {
}

Gdk.set_allowed_backends ("wayland");
//FIXME This should not have a null parameter
wayland_display = Gdk.Display.open (null);
//FIXME This should not have a null parameter
Gdk.set_allowed_backends (null);

if (wayland_display == null) {
Expand All @@ -122,8 +128,8 @@ public class ExternalWindowWayland : ExternalWindow, GLib.Object {
return wayland_display;
}

public void set_parent_of (Gdk.Window child_window) {
if (!((Gdk.Wayland.Window) child_window).set_transient_for_exported (handle)) {
public void set_parent_of (Gdk.Surface child_window) {
if (!((Gdk.Wayland.Toplevel) child_window).set_transient_for_exported (handle)) {
warning ("Failed to set portal window transient for external parent");
}
}
Expand Down
6 changes: 3 additions & 3 deletions filechooser-portal/FileChooserChoice.vala
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class Files.FileChooserChoice : Gtk.Box {

var label = new Gtk.Label (label);
bind_property ("label", label, "label", BindingFlags.DEFAULT);
add (label);
append (label);

if (options.n_children () == 0) {
var check = new Gtk.CheckButton ();
Expand All @@ -42,7 +42,7 @@ public class Files.FileChooserChoice : Gtk.Box {
}
);

add (check);
append (check);
} else {
var combo = new Gtk.ComboBoxText ();
var iter = options.iterator ();
Expand All @@ -53,7 +53,7 @@ public class Files.FileChooserChoice : Gtk.Box {
}

bind_property ("selected", combo, "active-id", BindingFlags.BIDIRECTIONAL);
add (combo);
append (combo);
}
}
}