Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When opened with specific file to select, the view is not showing that file #2214

Open
davidak opened this issue Jun 10, 2023 · 4 comments · May be fixed by #2280
Open

When opened with specific file to select, the view is not showing that file #2214

davidak opened this issue Jun 10, 2023 · 4 comments · May be fixed by #2280

Comments

@davidak
Copy link

davidak commented Jun 10, 2023 •
edited

What Happened?

When i select "Open in File Browser..." in Rapid Photo Downloader, Files is opened and the file is selected, but it is not shown in the view. I have to scroll down to see it.

Demonstration Video: https://www.youtube.com/watch?v=QoJYM3_LbUE

Rapid Photo Downloader uses the Python Library show-in-file-manager to do it, which basically does:

io.elementary.files FILE

With that, the issue is easily reproducible.

Steps to Reproduce

  1. Open Terminal
  2. Open Files
  3. Copy this command in Terminal io.elementary.files, add a Whitespace
  4. Scroll down in a folder with many files in Files and drag-and-drop a file from far down into the terminal, to get it's full path
  5. Close Files
  6. Run the command in Terminal, e.g. io.elementary.files '/home/davidak/2023-06-10_14-28-09.mkv'
  7. Files is opened and you see the folder the selected file is in, you have to manually scroll down to see it

Expected Behavior

The view is scrolled automatically to show the selected file.

OS Version

Other Linux
NixOS 22.11.4479.d4a9ff82fc1

Software Version

Older release (I have not run all updates)
elementary-files-6.2.1

Log Output

No response

Hardware Info

No response
@jeremypw
Copy link
Collaborator

jeremypw commented Jun 13, 2023 •
edited

The command line that the FileManager1 service uses is io.elementary.files -t [URL]. Using either command in a terminal works as expected for me provided Files is not already running. I find that if Files is already running and is already showing the required folder then it does not scroll to the requested item so there is an issue here. I am running the latest version but I do not think this part of the code was touched recently.

@jeremypw
Copy link
Collaborator

jeremypw commented Jul 7, 2023

Pushing to queue for fixes in the Gtk4 of Files.

@jeremypw jeremypw linked a pull request Aug 9, 2023 that will close this issue
Open
3 tasks
@jeremypw
Copy link
Collaborator

jeremypw commented Aug 9, 2023

Decided to fix now as some Gtk3 work is still happening and it touches parts of the code that will not change in Gtk4.

@jeremypw
Copy link
Collaborator

jeremypw commented Feb 4, 2024

@davidak Are you able to test the linked PR? Unfortunately it has not attracted attention from reviewers yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filemanager1 scroll to item elementary/files
2 participants
@davidak @jeremypw