Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [container] add validation for the direction prop #16734

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(components): [container] add validation for the direction prop #16734

wants to merge 1 commit into from
+19 −2

Conversation

chenyuqiua
Copy link

@chenyuqiua chenyuqiua commented Apr 30, 2024 •
edited

  • I found that the orientation attribute of the Container component was not validated.
  • So I added enumeration value validation to the component.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

feat(components): add validation for the Container component properties
98ee551 
- I found that the orientation attribute of the Container component was not validated.

- So I added enumeration value validation to the component
@pull-request-triage Pull Request Triage
Copy link

👋 @chenyuqiua, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 30, 2024
@github-actions GitHub Actions
Copy link

Hello @chenyuqiua, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16734
Please comment the example via this playground if needed.

@btea btea changed the title feat(components): Add validation for the Container component properties feat(components): [container] add validation for the direction prop May 3, 2024
btea
btea approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@chenyuqiua chenyuqiua

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenyuqiua @btea