feat: Add autoformat and lint for ts/tsx files #26453
Open
+211
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
t3chguy
reviewed
Nov 9, 2023
t3chguy
reviewed
Nov 9, 2023
Palid
force-pushed
the
feat/lint-staged
branch
from
b76b5c1
to
3b42712
Compare
t3chguy
requested changes
Nov 22, 2023
Palid
force-pushed
the
feat/lint-staged
branch
3 times, most recently
from
7dc6971
to
1f86a2b
Compare
Palid
force-pushed
the
feat/lint-staged
branch
from
1f86a2b
to
6cd6d42
Compare
|
@t3chguy what about now? |
t3chguy
reviewed
Nov 22, 2023
| { | ||
| "src/**/*.(ts|tsx)": ["eslint --fix"], | ||
| "module_system/**/*.(ts|tsx)": ["eslint --fix --config .eslintrc-module_system.js module_system"], | ||
| "**/*.(ts|tsx)": ["prettier --write"], |
There was a problem hiding this comment.
Seems like prettier isn't running on pcss, md, json, etc
Comment on lines
+2
to
+4
| "src/**/*.(ts|tsx)": ["eslint --fix"], | ||
| "module_system/**/*.(ts|tsx)": ["eslint --fix --config .eslintrc-module_system.js module_system"], | ||
| "**/*.(ts|tsx)": ["prettier --write"], |
There was a problem hiding this comment.
Won't these possibly conflict/race with each other as they are run in parallel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of autoformatting&autolinting on precommit hook.
Solves #18230 (2/3)
This change is marked as an internal change (Task), so will not be included in the changelog.