Remove message audio element (for another pr) #25477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
Z-Community-PR
|
Cannot pass test because |
germain-gg
suggested changes
Jun 26, 2023
|
Hmm... seems true. Currently it works because sound other than message ringtone hasn't been played... Will try to do that more thoroughly :D |
…kenvery/webaudioapi
Not sure what `remoteAudio` does, seems only used in tests, so I left it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Works with matrix-org/matrix-react-sdk#10995
Signed-off-by: 许煜恒 [email protected]
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes