Make Inter font paths relative. #20040
Conversation
Currently, paths look like /fonts/Inter which is fine if Element is installed in the wwwroot. This change makes the paths relative (./fonts/Inter) which helps when it's not. Credit goes to @rkfg. Fixes element-hq#17575.
There was a problem hiding this comment.
Thank you for raising that concern. It appears that you're not the only one to face this issue as I can see some reverse proxy rules on some config that deal exactly with that.
I'm not convinced that this the approach I'd want us to take to fix this particular problem. Dabbling with the HtmlWebpackConfig sounds a bit more maintanable and will convey the intent a bit better.
It appears that the path or publicPath option seems to achieve what you're after.
I'd also be curious to understand why this is an issue for this scenario and not for the JavaScript bundles
This = fonts? Looking at DevTools, with Element 1.9.5 everything loads fine (so I guess via relative paths) except for these fonts. |
|
yes, this = fonts |
|
That's fair enough. I don't know how to do that. |
Currently, paths look like /fonts/Inter which is fine if Element is installed in the wwwroot.
This change makes the paths relative (./fonts/Inter) which helps when it's not.
Credit goes to @rkfg.
Fixes #17575.
This change is marked as an internal change (Task), so will not be included in the changelog.