Missing comma and I would also take the ellipsis away #17233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
took me a while to find the mistake and "comment" and I think it'll take other even longer...
|
Your example is still invalid, just in a different way.
It is why it was the way it was with the |
turt2live
requested changes
May 11, 2021
|
Should I open an issue for this then? The code is invalid but it still works, what's are username colors? I'm assuming avatar background colors are the generated profile pictures? |
|
I think the missing comma is definitely a mistake though is it not? |
|
|
Ah 🤦 thx 😊 |
jryans
changed the title
turt2live
approved these changes
Mar 18, 2022
auto-merge was automatically disabled
January 8, 2024 12:36
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
took me a while to find the mistake and "comment" and I think it'll take other even longer...
Signed-off-by: Chagai Friedlander [email protected]