-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade to blueprintjs@4 #1160
base: main
Are you sure you want to change the base?
Conversation
Quite funny to see this test fail here.
Not sure what's going wrong here 🤔 |
Hey! I took a look at the failing test- in the interest of moving the PR forward, we can write the test using a snapshot instead as it seems that the wrapper is pulling some funnys ;) We should rewrite the next test for the same reason- the wrapper may be giving us a false positive. Here's a gist describing what I'm thinking. This would be similar to how we test menu items in the general appearance settings |
@georgexu99, that seems reasonable. Could you open a PR for just that change? This one is pretty big and hairy to review, so would be easier to land that generic test refactor separately. |
Actually, I already have these changes in my local branch - https://github.com/aryanshridhar/fiddle/tree/Add-VersionSelectSnapshots |
@aryanshridhar, can we rebase this PR and get it clean again? I can further look into the test failure after that. 🙂 |
e5b8312
to
24a8299
Compare
Rebased @dsanders11. |
Upgrades
blueprintjs
to v4 (4.8.0)This also upgrades the following packages with it -
to make sure that the codebase relies on only v4 version of
blueprintjs/core
-Fixes #1045