Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blocking of iframe based analytics #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mzsanford
Copy link

@mzsanford mzsanford commented Jul 9, 2020

During a GDPR project I came across the Amazon Attribution tracker, which uses an iframe instead of a script tag. This pull request allows Yett to also catch this specific type of dynamic iframe by re-directing the src attribute to yett-src and then moving it back on unblock.

The intent here is similar to #6 but I've attempted the least invasive change and added the feature flag window.YETT_IFRAME to make this opt-in only.

My knowledge of karma is lacking and I was unable to make a working test even after hours of attempts. Any help in adding a test would be greatly appreciated.

@pronego-mls
Copy link

Hi, I just stumpled over your extension.
I have a simple <iframe src="https://www.google.com/maps/embed..."> integration and was expecting that your extension is going to block it. But the iframe content is still loaded.
I I have added /google\.com/ to the blacklist array and enabled your extension with window.YETT_IFRAME = true
Am I missing something?
Any help appreciated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants