Update CONTRIBUTING.md to include icon specifications #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix icon name
fix viewbox icon
Fixed an error
add new icons
fix missing icon
Added quatt svg line
Added Quatt into the table
New version with 2px border spacing around the icon
Added border around quatt logo
Added padding into the quatt icon
Added quatt logo
add new icons
Added new icons
Add new Icons
Added verbiage for icons to be 20x20 within a 24x24 viewbox.
|
Will also have to update readme |
|
remove image as its confusing for people that dont deal with SVG's normally. I would put the size of the view box must be 24x24 the size of the icon in view box must be 20x20 and centred ill give you an example of the sillyness it can cause, take the ike one, when redownloaded it had resized it self to 15x15, but it can go both ways it can resize itself upto 3000x3000 which we have had previously. |
rchiileea
requested changes
Sep 6, 2024
rchiileea
requested changes
Sep 6, 2024
There was a problem hiding this comment.
- The size of the icons must be 24px by 24px. (change to The size of the SVG must be)
- The size of the viewbox must be 24px by 24px.
- The icon in the box must have a 2px border around it minumum and should not protrude into this area.
again everything else looks fine apart from that wording
|
#768 created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the updated wording convey the specifications described in #753 ?
I was going back in forth between:
or
or