feat(deploy-my-kibana): use github secrets #142
Conversation
| comment_url: https://github.com/elastic/kibana/pull/195219#issuecomment-2397814616 | ||
| comment_id: 2397814616 | ||
| issue_url: https://api.github.com/repos/elastic/kibana/issues/195219 | ||
| repository: 'elastic/kibana' |
There was a problem hiding this comment.
I use elastic/kibana#195219 (comment), however the command is not what we use in production, but wanted to use a real GitHub comment but using a PR owned by me - to avoid spamming people
There was a problem hiding this comment.
I changed the comment to be used so i could benefit from the default permissions at the workflow level, the GH app does not have permissions to all the GH repositories but jus a subset... so using the GH actions permissions we can simplify the need to add more GH repositories
…ibana-1 * upstream/main: feat: github/comment-reaction (#143)
| | `comment-id` | The GitHub Comment ID | `false` | `${{ github.event.comment.id }}` | | ||
| | `issue-url` | The GitHub Issue URL | `false` | `${{ github.event.comment.issue_url }}` | | ||
| | `repository` | The GitHub repository | `false` | `${{ github.repository }}` | | ||
| | `user` | The GitHub user that triggered the workflow | `false` | `${{ github.triggering_actor }}` | |
There was a problem hiding this comment.
I just took a look at https://github.com/elastic/oblt-actions/tree/main/github/is-member-of
and I feel like we have an inconsistency with naming inputs.
This is not blocking, but we might want to think about when to prefix with github- or not.
maybe we can revisit this when we eventually need to release v2
| installation_retrieval_mode: organization | ||
| installation_retrieval_payload: elastic |
There was a problem hiding this comment.
@reakaleek , if you use the GH app action in a GH repository which does not have installed the GH app, then you need these two parameters, otherwise you will see some errors like the ones in #144
There was a problem hiding this comment.
Uh, interesting. thanks for the info
There was a problem hiding this comment.
installation_retrieval_mode: id
...
does not work, see tibdex/github-app-token#102
What
Replace https://github.com/elastic/apm-pipeline-library/tree/main/.github/actions/deploy-my-kibana with GitHub secrets and support only for no serverless.
Issues
Requires #143
Test
See #59 (comment)
and a link to the GH private repository can be seen in this PR