[Cases] Fix flaky hooks #183721
Merged
[Cases] Fix flaky hooks #183721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
added
the
release_note:skip
adcoelho
approved these changes
May 17, 2024
Comment on lines
+42
to
+44
| await waitFor(() => { | ||
| expect(spy).toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| await waitFor(() => { | |
| expect(spy).toHaveBeenCalled(); | |
| }); | |
| await waitFor(() => { | |
| expect(spy).toHaveBeenCalledWith({ | |
| http, | |
| signal: expect.anything(), | |
| connectorId: connector.id, | |
| }); | |
| }); |
and remove line 46 and below?
There was a problem hiding this comment.
I do this because if we have the toHaveBeenCalledWith inside the waitFor, we do not know if the expect failed because the function did not get called with the correct arguments or did not call at all. The logs will not show anything in the CI. This way, in the case of a flaky test, the logs will show the expected args.
Comment on lines
+43
to
+45
| await waitFor(() => { | ||
| expect(spyOnGetCurrentUserProfile).toBeCalled(); | ||
| }); |
There was a problem hiding this comment.
Same as above(removing line 47)
Suggested change
| await waitFor(() => { | |
| expect(spyOnGetCurrentUserProfile).toBeCalled(); | |
| }); | |
| await waitFor(() => { | |
| expect(spyOnGetCurrentUserProfile).toBeCalledWith({ | |
| security: expect.anything(), | |
| }); | |
| }); |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @cnasikas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #183144, #182845
Checklist
Delete any items that are not applicable to this PR.
For maintainers