Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables Rebuild] Migrate Visualize #183197

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

[Embeddables Rebuild] Migrate Visualize #183197

wants to merge 81 commits into from
+2,951 −1,989

Commits on Apr 24, 2024

  1. Initial commit, register react visualize embeddable based on EUI mark… 

    …down example
    @Zacqary
    Zacqary committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    98ef1fd View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Get initial expression updater logic working

    @Zacqary
    Zacqary committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7d2c26f View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. WIP

    @Zacqary
    Zacqary committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2ca806b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Get visualizations rendering in embeddable

    @Zacqary
    Zacqary committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1d86a45 View commit details
    Browse the repository at this point in the history

  2. Add types to expression renderer props

    @Zacqary
    Zacqary committed May 6, 2024
    Configuration menu
    Copy the full SHA
    806a98c View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add types and fix visualization saving

    @Zacqary
    Zacqary committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a9633f4 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion
    @Zacqary
    Zacqary committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9c7377a View commit details
    Browse the repository at this point in the history

  2. Implement actions

    @Zacqary
    Zacqary committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d08e1f7 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion
    @Zacqary
    Zacqary committed May 9, 2024
    Configuration menu
    Copy the full SHA
    48e51e6 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Get state serialization/deserialization working

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8afa840 View commit details
    Browse the repository at this point in the history

  2. Deprecate legacy embeddable

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d655091 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion

# Conflicts:
#	src/plugins/visualizations/public/plugin.ts
    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f87d0ac View commit details
    Browse the repository at this point in the history

  4. Revert services reorg

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6910163 View commit details
    Browse the repository at this point in the history

  5. Revert dataViews dep

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e39ca14 View commit details
    Browse the repository at this point in the history

  6. Use existing apiPublishesSettings

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0fa4d8f View commit details
    Browse the repository at this point in the history

  7. Remove embeddable debugger flag

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4add2da View commit details
    Browse the repository at this point in the history

  8. Use existing start getter

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1ca2ce3 View commit details
    Browse the repository at this point in the history

  9. Remove unused savedObjects dep

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6b6e8ec View commit details
    Browse the repository at this point in the history

  10. Add viewMode subject

    @Zacqary
    Zacqary committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a590306 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'main' into visualize-embeddable-react-converstion

    @kibanamachine
    kibanamachine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b9cc3a4 View commit details
    Browse the repository at this point in the history

  2. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3708ab0 View commit details
    Browse the repository at this point in the history

  3. Revert extractReferences type change

    @Zacqary
    Zacqary committed May 13, 2024
    Configuration menu
    Copy the full SHA
    347f066 View commit details
    Browse the repository at this point in the history

  4. Revert injectReferences type change

    @Zacqary
    Zacqary committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5501a96 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/visualize-embeddable-react-conve… 

    …rstion' into visualize-embeddable-react-converstion
    @Zacqary
    Zacqary committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8b5bfe9 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Add savedobject deserialization

    @Zacqary
    Zacqary committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c1d56e3 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'main' into visualize-embeddable-react-converstion

    @kibanamachine
    kibanamachine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3587f7c View commit details
    Browse the repository at this point in the history

  2. WIP

    @Zacqary
    Zacqary committed May 15, 2024
    Configuration menu
    Copy the full SHA
    db5c257 View commit details
    Browse the repository at this point in the history

  3. Port TSVB editor to React embeddable

    @Zacqary
    Zacqary committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6c915cc View commit details
    Browse the repository at this point in the history

  4. Handle undefined state in deserializeState

    @Zacqary
    Zacqary committed May 15, 2024
    Configuration menu
    Copy the full SHA
    eae8f8d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'visualize-embeddable-react-converstion' of https://gith… 

    …ub.com/Zacqary/kibana into visualize-embeddable-react-converstion
    @Zacqary
    Zacqary committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8a8c375 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Use React embeddable in Default Editor, sidebar not yet migrated

    @Zacqary
    Zacqary committed May 17, 2024
    Configuration menu
    Copy the full SHA
    818f433 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Fix reference injection

    @Zacqary
    Zacqary committed May 20, 2024
    Configuration menu
    Copy the full SHA
    1997b37 View commit details
    Browse the repository at this point in the history

  2. Implement triggers in react embeddable

    @Zacqary
    Zacqary committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d4a3fec View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Implement inspector button in tsvb editor

    @Zacqary
    Zacqary committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6a57013 View commit details
    Browse the repository at this point in the history

  2. Implement inspector on default editor

    @Zacqary
    Zacqary committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b3b5e22 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7d1d93b View commit details
    Browse the repository at this point in the history

  2. Remove legacy visualizeembeddable

    @Zacqary
    Zacqary committed May 22, 2024
    Configuration menu
    Copy the full SHA
    027bd97 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion

# Conflicts:
#	packages/presentation/presentation_containers/index.ts
    @Zacqary
    Zacqary committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8ab5b31 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'visualize-embeddable-react-converstion' of https://gith… 

    …ub.com/Zacqary/kibana into visualize-embeddable-react-converstion
    @Zacqary
    Zacqary committed May 22, 2024
    Configuration menu
    Copy the full SHA
    36ebfb1 View commit details
    Browse the repository at this point in the history

  5. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0720581 View commit details
    Browse the repository at this point in the history

  6. Run i18n fix

    @Zacqary
    Zacqary committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5eee91d View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion

# Conflicts:
#	src/plugins/visualizations/public/embeddable/visualize_embeddable.tsx
    @Zacqary
    Zacqary committed May 22, 2024
    Configuration menu
    Copy the full SHA
    10da106 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Update visualize editor parentApis

    @Zacqary
    Zacqary committed May 23, 2024
    Configuration menu
    Copy the full SHA
    108003e View commit details
    Browse the repository at this point in the history

  2. Typecheck fix

    @Zacqary
    Zacqary committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5473d35 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Fix missing test subjs

    @Zacqary
    Zacqary committed May 28, 2024
    Configuration menu
    Copy the full SHA
    76cdc32 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion
    @Zacqary
    Zacqary committed May 28, 2024
    Configuration menu
    Copy the full SHA
    160e34d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge remote-tracking branch 'upstream/main' into visualize-embeddabl… 

    …e-react-converstion
    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2603dd7 View commit details
    Browse the repository at this point in the history

  2. Clean up subjects and move async deserialize logic into deserializeState

    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    dee7dde View commit details
    Browse the repository at this point in the history

  3. Fix markdown editor

    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0e80a0a View commit details
    Browse the repository at this point in the history

  4. Add error prompt to broken vis loaders

    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    300686f View commit details
    Browse the repository at this point in the history

  5. Fix index pattern saving in agg embeddables

    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3a9aa48 View commit details
    Browse the repository at this point in the history

  6. Fetch index pattern from savedSearch

    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    aac4b63 View commit details
    Browse the repository at this point in the history

  7. Reinstate data-shared-item attr

    @Zacqary
    Zacqary committed May 29, 2024
    Configuration menu
    Copy the full SHA
    57e2c57 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Fix missing data-shared-item props

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    cf772ea View commit details
    Browse the repository at this point in the history

  2. Fix emitting visdata

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1921e9d View commit details
    Browse the repository at this point in the history

  3. Fix FTR 3 - data-rendering-complete

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    714987c View commit details
    Browse the repository at this point in the history

  4. Fix reference migration

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    06e4aa5 View commit details
    Browse the repository at this point in the history

  5. Reimplement hasInspector

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    fe39bd4 View commit details
    Browse the repository at this point in the history

  6. Fix navigate to lens from visualize

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    c377731 View commit details
    Browse the repository at this point in the history

  7. Fix updating aggregation vis in editor

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b42a21b View commit details
    Browse the repository at this point in the history

  8. Force empty data-title and data-description

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    46567d2 View commit details
    Browse the repository at this point in the history

  9. Clear data-title when hidePanelTitle is true

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    986c432 View commit details
    Browse the repository at this point in the history

  10. Catch error when searchSource ref is missing

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    6cd153e View commit details
    Browse the repository at this point in the history

  11. Fix tag cloud test

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d52b1a6 View commit details
    Browse the repository at this point in the history

  12. Move waitForVisualization into clickGo

    @Zacqary
    Zacqary committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e3840c1 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Implement add from library

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    13f85f7 View commit details
    Browse the repository at this point in the history

  2. Fix saving title from visualize app

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    95eed5e View commit details
    Browse the repository at this point in the history

  3. Fix i18n

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    270b560 View commit details
    Browse the repository at this point in the history

  4. Pass navigateToLensFn directly to visualize topnav

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    149443d View commit details
    Browse the repository at this point in the history

  5. Skip tag cloud tests

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c2d4582 View commit details
    Browse the repository at this point in the history

  6. Add library linking actions

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    aaa078c View commit details
    Browse the repository at this point in the history

  7. Import index pattern references in default editor

    @Zacqary
    Zacqary committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8e1cd68 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. WIP Visualize Editor refactor

    @Zacqary
    Zacqary committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    eb41aa2 View commit details
    Browse the repository at this point in the history

  2. Clean up top nav saving

    @Zacqary
    Zacqary committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7f4f55f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fix save and load from savedobject editor

    @Zacqary
    Zacqary committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    dd49ca4 View commit details
    Browse the repository at this point in the history

  2. Fix editor breadcrumbs for savedobject editor

    @Zacqary
    Zacqary committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7ab95f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Commit breadcrumbs hook

    @Zacqary
    Zacqary committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ec52b76 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Restore working legacy tsvb editors

    @Zacqary
    Zacqary committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7a0bf7e View commit details
    Browse the repository at this point in the history

  2. Fix imports

    @Zacqary
    Zacqary committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    20562a1 View commit details
    Browse the repository at this point in the history

  3. Fix saving and loading on byvalue and default editors

    @Zacqary
    Zacqary committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9444ebe View commit details
    Browse the repository at this point in the history

  4. Cleanup types

    @Zacqary
    Zacqary committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    19cc33e View commit details
    Browse the repository at this point in the history