Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] make parent nav item into breadcrumb link #183189

Merged
merged 4 commits into from May 16, 2024
Merged

[Serverless] make parent nav item into breadcrumb link #183189

merged 4 commits into from May 16, 2024

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented May 10, 2024 •
edited

Summary

Currently the breadcrumb of the parent navigation item isn't a link:

Screenshot 2024-05-10 at 2 06 42 PM

This change makes it so the breadcrumb of parent navigation item is linkable:
Screenshot 2024-05-10 at 2 21 27 PM

The links will go to the first item in the list of child links.

The merging of this PR depends on #183508 allows for this functionality to work without making the left side parent collapsible link, also a href link - only the breadcrumb.

Testing

  • Start a serverless kibana instance

  • Navigate to a child link of an accordion using the left side navigation

Screenshot 2024-05-15 at 11 26 24 AM
  • The breadcrumb should of this page should be a link and link you to the first child link of the accordion

@neptunian neptunian added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels May 10, 2024
@neptunian neptunian requested a review from a team as a code owner May 10, 2024 18:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 10, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

dominiqueclarke
dominiqueclarke approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebelga sebelga added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label May 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@neptunian neptunian marked this pull request as draft May 13, 2024 12:10
@neptunian
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 15, 2024 •
edited

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 26.4KB 26.5KB +97.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian marked this pull request as ready for review May 15, 2024 17:57
@neptunian neptunian requested a review from a team as a code owner May 15, 2024 17:57
neptunian
neptunian commented May 15, 2024
View reviewed changes
x-pack/plugins/serverless_observability/public/navigation_tree.ts
@@ -80,6 +81,7 @@ export const navigationTree: NavigationTreeDefinition = {
defaultMessage: 'Anomaly detection',
}),
link: 'ml:anomalyDetection',
id: 'ml:anomalyDetection',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an ID to this link because now that we have more than one link in the same page, the test-subj values end up being the same as it uses the link value. The wrong link then gets clicked. I used the same value as the "deepLinkId" in link which I hope isn't confusing.

tonyghiani
tonyghiani approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neptunian neptunian merged commit 99ab2f4 into elastic:main May 16, 2024
19 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@neptunian @elasticmachine @apmmachine @kibana-ci @dominiqueclarke @tonyghiani @sebelga @kibanamachine