[Index Management] Fix mapping_tab error due to _data_stream_timestamp #183187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikatsarkar056
added
Team:EnterpriseSearch
release_note:skip
saikatsarkar056
changed the title
|
@elasticmachine merge upstream |
|
/ci |
|
Hi @saikatsarkar056 this change looks good. However, I would like to validate it on a cloud deployment before merging as I'm still a little confused why I saw 2 different types of errors. I want to make sure both are addressed. |
|
@saikatsarkar056 I verified your change on cloud and everything looks good 👍. I'm going to ask an engineer on my team do the code review. 
|
yuliacech
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks a lot for fixing this, @saikatsarkar056!
Code changes LGTM 👍
I think we are missing an e2e test for the index details page so I'll open an issue to track that.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
added
the
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2024
elastic#183187) (cherry picked from commit 3d79d43)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 13, 2024
…imestamp (#183187) (#183306) # Backport This will backport the following commits from `main` to `8.14`: - [[Index Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)](#183187) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saikat Sarkar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-13T15:15:19Z","message":"[Index Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)","sha":"3d79d4349443608c92ad42b981d5f010921af97f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:EnterpriseSearch","backport:prev-minor","ci:cloud-deploy","v8.14.0","v8.15.0"],"title":"[Index Management] Fix mapping_tab error due to _data_stream_timestamp","number":183187,"url":"#183187 Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)","sha":"3d79d4349443608c92ad42b981d5f010921af97f"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183187 Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)","sha":"3d79d4349443608c92ad42b981d5f010921af97f"}}]}] BACKPORT--> Co-authored-by: Saikat Sarkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error or warning message is displayed on the index mappings tab when viewing mappings for a backing index. This looks like _data_stream_timestamp is missing in the mappingsConfigurationSchema.
Fixes #183055
Screen-recording after bug-fix
Screen.Recording.2024-05-10.at.11.47.03.AM.mov