[Obs AI Assistant] OpenAPI spec for public API #183151
Draft
+324
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dgieselaar
force-pushed
the
obs-ai-assistant-openapi-docs
branch
from
b657fd9
to
b30d428
Compare
jloleysens
reviewed
May 10, 2024
| title: Elastic AI Assistant for Observability | ||
| version: 1.0.0 | ||
| paths: | ||
| "/api/observability_ai_assistant/chat/complete": |
There was a problem hiding this comment.
Nice! Not sure it's in this PR code, what generated this spec?
There was a problem hiding this comment.
it's here: https://github.com/elastic/kibana/pull/183151/files#diff-012b20f075e09f40a1839b759082ffea0122aeb79d6b5fd5e642f9abee2435e2, from there it's mostly JSON to YML if needed which is fairly trivial
There was a problem hiding this comment.
we can do it automatically if we have an API from core, but I'm not sure if we can get to full coverage. custom io-ts types are ignored for instance.
There was a problem hiding this comment.
Oh sorry, my q was not clear: I meant the entire OAS document. The schema parts were generated, but the openapi, info parts were manually added by you?
|
Yes, just copied that over from some existing docs in APM
Op vr 10 mei 2024 17:08 schreef Jean-Louis Leysens ***@***.***
…:
***@***.**** commented on this pull request.
------------------------------
In
x-pack/plugins/observability_solution/observability_ai_assistant/docs/openapi/api.yaml
<#183151 (comment)>:
> @@ -0,0 +1,126 @@
+openapi: 3.0.0
+info:
+ title: Elastic AI Assistant for Observability
+ version: 1.0.0
+paths:
+ "/api/observability_ai_assistant/chat/complete":
Oh sorry, my q was not clear: I meant the entire OAS document. The schema
parts were generated, but the openapi, info parts were manually added by
you?
—
Reply to this email directly, view it on GitHub
<#183151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWDXAR6EBWH7FOGV2SKUTZBTPGBAVCNFSM6AAAAABHQTH2WGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJQGI4DKMBZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an OpenAPI spec for the public API.