github-actions: use github secrets (#489)

.github/workflows/smoke-tests.yml

@@ -30,24 +30,16 @@ jobs:
       TF_VAR_REPO: "${{ github.repository }}"
       SMOKETEST_VERSIONS: "${{ inputs.smoketest_versions || 'latest' }}"
       SKIP_DESTROY: 0
+      # TODO: replace with keyless (likely AWS and Google Secrets Manager)
+      AWS_ACCESS_KEY_ID: ${{ secrets.OBSERVABILITY_AWS_ACCESS_KEY_ID }}
+      AWS_SECRET_ACCESS_KEY: ${{ secrets.OBSERVABILITY_AWS_SECRET_ACCESS_KEY }}
+      EC_API_KEY: ${{ secrets.OBSERVABILITY_EC_API_KEY }}
     steps:
       - uses: actions/checkout@v4
       - name: Bootstrap Action Workspace
         uses: ./.github/actions/bootstrap
         with:
           goreleaser: 'true'
-      # TODO: replace with keyless (likely AWS and Google Secrets Manager)
-      - name: Import Secrets
-        uses: hashicorp/[email protected]
-        with:
-          url: ${{ secrets.VAULT_ADDR }}
-          method: approle
-          roleId: ${{ secrets.VAULT_ROLE_ID }}
-          secretId: ${{ secrets.VAULT_SECRET_ID }}
-          secrets: |
-            secret/observability-team/ci/elastic-observability-aws-account-auth access_key | AWS_ACCESS_KEY_ID ;
-            secret/observability-team/ci/elastic-observability-aws-account-auth secret_key | AWS_SECRET_ACCESS_KEY ;
-            secret/observability-team/ci/elastic-cloud/observability-team-pro apiKey | EC_API_KEY
       - uses: hashicorp/setup-terraform@v3
         with:
           terraform_version: 1.2.3