Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update CODEOWNERS #1624

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: update CODEOWNERS #1624

wants to merge 2 commits into from

Conversation

kruskall
Copy link
Member

No description provided.

@kruskall kruskall requested a review from a team as a code owner May 17, 2024 02:41
@dmathieu
Copy link
Member

Should we then delete the @elastic/apm-agent-go team?
Alternative: we could keep the owners file as-is, and change the members of the team?

@dmathieu
Copy link
Member

cc @elastic/obs-ds-ebpf-go

@rockdaboot
Copy link
Contributor

Should we then delete the @elastic/apm-agent-go team?
Alternative: we could keep the owners file as-is, and change the members of the team?

The goal should be that people who are not directly involved in the maintenance of apm-agent-go or in the development of the lambda extension won't get GH notification emails ("reducing noise" for developers). And I don't think that every team member of @elastic/obs-ds-ebpf-go will be directly involved here. One way to achieve less noise is having more fine-grained GH groups.

Ideally, the decision on how to move forward is made by @AlexanderWert and @simitt.

@dmathieu
Copy link
Member

If we don't want everyone from obs-ds-ebpf-go to get notifications, then keeping the team and changing its members seems like the best way.

@simitt
Copy link
Contributor

simitt commented May 21, 2024

Ideally, the decision on how to move forward is made by @AlexanderWert and @simitt.

This is team internal to how the work is split up within the obs-ds-ebpf-go team, so leaving this to @AlexanderWert;
happy to remove the current members from https://github.com/orgs/elastic/teams/apm-agent-go and add new members to it, or completely sunset the apm-agent-go team.

@kruskall kruskall changed the base branch from main to 2.x September 11, 2024 18:48
@kruskall kruskall changed the base branch from 2.x to v2.4 September 11, 2024 18:49
@kruskall kruskall changed the base branch from v2.4 to updatecli_main_9bc32f73c7425e5d7d6a3e394780b3da48a426b42465b81f2ee642f0d3fe10e3 September 11, 2024 20:56
@kruskall
Copy link
Member Author

run docs-build

@kruskall kruskall changed the base branch from updatecli_main_9bc32f73c7425e5d7d6a3e394780b3da48a426b42465b81f2ee642f0d3fe10e3 to main September 11, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants