Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dependencies changes that are making release workflow fail #8157

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

TiberiuGC
Copy link
Collaborator

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the skip-release-notes Causes PR not to show in release notes label Jan 22, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TiberiuGC - let's revert this back and fix the build images - once we make a release. cc @bryantbiggs

@bryantbiggs
Copy link
Member

thanks @TiberiuGC ! - I have a follow up PR (once the release has been cut and we're get that unblocked) that I believe will fix this release workflow issue #8158

@TiberiuGC TiberiuGC marked this pull request as ready for review January 22, 2025 23:27
@TiberiuGC TiberiuGC merged commit 5c8b046 into eksctl-io:main Jan 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants