feat(ci): change pre-commit clang-format to run in ci [skip pre-commit.ci]

.clang-format

@@ -3,7 +3,7 @@ BasedOnStyle:  LLVM
 BreakConstructorInitializersBeforeComma: true
 ConstructorInitializerAllOnOneLineOrOnePerLine: true
 Cpp11BracedListStyle: true
-Standard: Cpp11
+Standard: c++20
 #SpaceBeforeParens: ControlStatements
 SpaceAfterControlStatementKeyword: true
 PointerBindsToType: true
@@ -12,4 +12,6 @@ UseTab:          Never
 ColumnLimit:     100
 NamespaceIndentation: Inner
 AlignConsecutiveAssignments: true
+SortIncludes: Never
+ReflowComments: false
 ...

.clang-format-ignore

@@ -0,0 +1 @@
+docs/*.json

.clang-tidy

@@ -6,6 +6,7 @@ Checks: '
   modernize-*,
   portability-*,
   readability-*,
+  -bugprone-macro-parentheses,
   -bugprone-unchecked-optional-access,
   -modernize-use-trailing-return-type,
   -modernize-avoid-c-arrays,

.devcontainer/devcontainer.json

@@ -1,13 +1,13 @@
 {
-    "image": "ghcr.io/eic/jug_prod:master-nightly",
-    "postCreateCommand": "./.devcontainer/postCreateCommand.sh",
-    "customizations": {
-        "vscode": {
-            "extensions": [
-                "ms-vscode.cmake-tools",
-                "ms-vscode.cpptools",
-                "ms-vscode.cpptools-extension-pack"
-            ]
-        }
+  "image": "ghcr.io/eic/jug_prod:master-nightly",
+  "postCreateCommand": "./.devcontainer/postCreateCommand.sh",
+  "customizations": {
+    "vscode": {
+      "extensions": [
+        "ms-vscode.cmake-tools",
+        "ms-vscode.cpptools",
+        "ms-vscode.cpptools-extension-pack"
+      ]
     }
+  }
 }

.github/workflows/linux-eic-shell.yml

@@ -155,7 +155,7 @@ jobs:
       with:
         platform-release: "${{ env.platform-release }}"
         run: |
-          git diff ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.base.sha }} | clang-tidy-diff -p 1 -path build -quiet -export-fixes clang_tidy_fixes.yml -extra-arg='-std=c++20' -checks='-*,bugprone-*,-bugprone-narrowing-conversions' -clang-tidy-binary run-clang-tidy
+          git diff ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.base.sha }} | clang-tidy-diff -p 1 -path build -quiet -export-fixes clang_tidy_fixes.yml -extra-arg='-std=c++20' -checks='-*,bugprone-*,-bugprone-narrowing-conversions,-bugprone-macro-parentheses' -clang-tidy-binary run-clang-tidy
     - name: Run clang-tidy on all files
       uses: eic/run-cvmfs-osg-eic-shell@main
       if: ${{ github.event_name == 'push' }}

.pre-commit-config.yaml

@@ -1,5 +1,3 @@
-ci:
-    skip: [clang-format]
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
   rev: v4.6.0
@@ -18,8 +16,8 @@ repos:
   - id: forbid-tabs
   - id: remove-tabs
     args: [--whitespaces-count, '8']
-- repo: https://github.com/pocc/pre-commit-hooks
-  rev: v1.3.5
+- repo: https://github.com/pre-commit/mirrors-clang-format
+  rev: v18.1.3
   hooks:
   - id: clang-format
 - repo: https://github.com/cheshirekow/cmake-format-precommit