-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bucket silicon raw hits in time #1359
base: main
Are you sure you want to change the base?
Conversation
Capybara summary for PR 1359 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about a similar thing, but for calorimetry. I suppose, for MAPS tracking this would look more like histogramming in time, rather than this. Otherwise looks like a fine first prototype.
I'm planning to do a similar thing for all hits, using this as a template as far as it's appropriate. |
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This PR should be ready to merge. Liaisons, please check I used the right values for resolution and integration window, and that the implementation makes some sense. |
Co-authored-by: Simon Gardner <[email protected]>
Briefly, what does this PR introduce?
For longer time slices, hits for a cellId cannot be integrated throughout the "event". This PR creates a new hit when the time stamp falls out of all existing hits'
[time, time+integration window]
.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes.