Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bucket silicon raw hits in time #1359

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: Bucket silicon raw hits in time #1359

wants to merge 26 commits into from

Conversation

kkauder
Copy link
Contributor

@kkauder kkauder commented Apr 2, 2024

Briefly, what does this PR introduce?

For longer time slices, hits for a cellId cannot be integrated throughout the "event". This PR creates a new hit when the time stamp falls out of all existing hits' [time, time+integration window].

  • Are the time resolution (or integration) values correct?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Yes.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about a similar thing, but for calorimetry. I suppose, for MAPS tracking this would look more like histogramming in time, rather than this. Otherwise looks like a fine first prototype.

src/algorithms/digi/SiliconTrackerDigi.cc Outdated Show resolved Hide resolved
src/algorithms/digi/SiliconTrackerDigiConfig.h Outdated Show resolved Hide resolved
src/algorithms/digi/SiliconTrackerDigi.cc Show resolved Hide resolved
@kkauder
Copy link
Contributor Author

kkauder commented Apr 3, 2024

I was thinking about a similar thing, but for calorimetry. I suppose, for MAPS tracking this would look more like histogramming in time, rather than this. Otherwise looks like a fine first prototype.

I'm planning to do a similar thing for all hits, using this as a template as far as it's appropriate.

@github-actions github-actions bot added topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: barrel topic: forward labels Apr 24, 2024
@kkauder
Copy link
Contributor Author

kkauder commented Jun 25, 2024

This PR should be ready to merge. Liaisons, please check I used the right values for resolution and integration window, and that the implementation makes some sense.

nschmidtALICE
nschmidtALICE previously approved these changes Jun 25, 2024
@veprbl veprbl changed the title [DONTMERGE] feat: Bucket silicon raw hits in time feat: Bucket silicon raw hits in time Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel topic: digitization topic: far-forward Far forward reconstruction topic: forward topic: infrastructure topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants