Skip to content

Commit

Permalink
feat: add CherenkovParticleID datatype (#17)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
Add new `datatype` for RICH PID: `CherenkovParticleID`. While we intend
to use `edm4hep::ParticleID` for the final RICH PID, it is useful to
have an intermediate, more detailed datatype specific for Cherenkov PID.

This is a refactor of what we used in Juggler for ATHENA; the branch
[`irt-data-model`](https://github.com/eic/EDM4eic/tree/irt-data-model)
should remain for legacy Juggler support (see #1) until we are fully
transitioned to EICrecon.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators: @chchatte92
@alexander-kiselev

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No

### Does this PR change default behavior?
No

---------

Co-authored-by: chchatte92 <[email protected]>
  • Loading branch information
c-dilks and chchatte92 authored Apr 13, 2023
1 parent b3066be commit c8ffba7
Showing 1 changed file with 24 additions and 1 deletion.
25 changes: 24 additions & 1 deletion edm4eic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ components:
- edm4eic::Cov2f directionError // Error on the polar and azimuthal angles
- float pathlength // Pathlength from the origin to this point
- float pathlengthError // Error on the pathlength

## PID hypothesis from Cherenkov detectors
edm4eic::CherenkovParticleIDHypothesis:
Members:
- int32_t PDG // PDG code
- float npe // Overall photoelectron count
- float weight // Weight of this hypothesis, such as likelihood, moment, etc.

datatypes:

Expand Down Expand Up @@ -265,8 +272,24 @@ datatypes:
- int32_t sector // The sector this hit occurred in
- edm4hep::Vector3f local // The local position of the hit in detector coordinates (relative to the sector) [mm]

edm4eic::CherenkovParticleID:
Description: "Cherenkov detector PID"
Author: "A. Kiselev, C. Chatterjee, C. Dilks"
Members:
- uint32_t radiator // Radiator number
- float npe // Overall photoelectron count
- float refractiveIndex // Average refractive index at the Cherenkov photons' vertices
- float photonEnergy // Average energy for these Cherenkov photons [GeV]
VectorMembers:
- edm4eic::CherenkovParticleIDHypothesis hypotheses // Evaluated PDG hypotheses
- edm4hep::Vector2f thetaPhiPhotons // estimated (theta,phi) for each Cherenkov photon
OneToOneRelations:
- edm4eic::TrackSegment chargedParticle // reconstructed charged particle
OneToManyRelations:
- edm4eic::MCRecoTrackerHitAssociation rawHitAssociations // raw sensor hits, associated with MC hits

edm4eic::RingImage:
##@TODO: RICH reconstruction still needs an overhaul
##@TODO: Juggler support; not used in EICrecon
Description: "EIC Ring Image Cluster"
Author: "S. Joosten, C. Peng"
Members:
Expand Down

0 comments on commit c8ffba7

Please sign in to comment.