Add functions #81
Closed
Add functions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
reviewed
Aug 7, 2020
field/TinyLang/Field/Type.hs
Outdated
| -- Types | ||
| data Type uni f | ||
| = BuiltIn (Some (TypeIn uni f)) | ||
| | TyFun (Type uni f) (Type uni f) |
There was a problem hiding this comment.
We parameterize Type by uni in Plutus, because we actually need the extensibility. We're not going to need it in Zonk any time soon and if we ever need it, it'll be straightforward to add. So just replace uni with Uni and have a single Type instead of Type + UniType.
There was a problem hiding this comment.
Ok, I simplified Type. I was considering simplifying TypeIn, but I will leave it as it is for now,
| deriving instance Ord (UniType f) | ||
|
|
||
| pattern Bool :: UniType f | ||
| pattern Bool = UniType U.Bool |
There was a problem hiding this comment.
Do we often need this "quick access"? I'd be fine with using UniType Bool explicitly instead of providing another term-level Bool name.
There was a problem hiding this comment.
So far we need it only in handful of places. Will see later about it.
added 8 commits
August 14, 2020 22:19
by inlining Uni into Type definition.
Because we do not support functions in Typed.Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32
At the moment I started using Type instead of Uni in Raw.
TypeandUniType.