Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishbone test #33

Closed
wants to merge 12 commits into from
Closed

Wishbone test #33

wants to merge 12 commits into from

Conversation

suppamax
Copy link

Issue #24

Copy link
Member

@marwaneltoukhy marwaneltoukhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase from wb_slave_address_fix branch

@marwaneltoukhy
Copy link
Member

Tried this out with the fix in wb_slave_address_fix branch, and both RTL and GL failed

@suppamax
Copy link
Author

According to #24 the size of the wishbone area is 0x10000000, but in the wb_slave_address_fix branch it is only 0x1000000

self.bus.add_slave(name="mprj", slave=mprj, region=SoCRegion(origin=self.mem_map["mprj"], size=0x1000000))

The test has been adapted to be compatible with the branch, but I am not sure it is what you really want.

@RTimothyEdwards RTimothyEdwards added duplicate This issue or pull request already exists invalid This doesn't seem right labels Oct 4, 2022
@marwaneltoukhy
Copy link
Member

Thank you everyone for your efforts on this. At this time, due to the age of this issue and other changes that have happened since, we have decided to close this PR without merging it. In some cases this also means there is now a better or other recommended approach, or possible the PR otherwise relates to a deprecated mode of use. Reviewed by @marwaneltoukhy @DavidRLindley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants