Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript rewrite #143

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Typescript rewrite #143

wants to merge 11 commits into from

Conversation

OmgImAlexis
Copy link
Contributor

@OmgImAlexis OmgImAlexis commented May 17, 2020

Not sure if this is worth opening or if I should just manage my own fork but this should get this repo back up and running. If you don't see any use in this feel free to close the PR.

Tests now pass. There are 2 sets of tests that needed to be removed. They'll need to be fixed at some point.

This closes #129 #142 #137 #135 #140 and #141

Most methods are now typed correctly instead of returning any so the users actually know what data is being returned.

I've also trimmed the package size.

dist/index.js   - 6.84 kB
dist/index.d.ts - 9.38 kB
Done in 3829ms
npm notice 
npm notice 📦  [email protected]
npm notice === Tarball Contents === 
npm notice 1.1kB LICENSE        
npm notice 6.8kB dist/index.js  
npm notice 1.4kB package.json   
npm notice 1.9kB README.md      
npm notice 9.4kB dist/index.d.ts
npm notice === Tarball Details === 
npm notice name:          node-tvdb                               
npm notice version:       6.0.0                                   
npm notice filename:      node-tvdb-6.0.0.tgz                     
npm notice package size:  5.7 kB                                  
npm notice unpacked size: 20.6 kB                                 
npm notice shasum:        7227520fa61c6073a38e07e6b571c5773b412cda
npm notice integrity:     sha512-c8fbrvLKx+OBV[...]lruOSYiv5p+Cw==
npm notice total files:   5                                       
npm notice 
node-tvdb-6.0.0.tgz

PING: @edwellbrook

@OmgImAlexis
Copy link
Contributor Author

Travis should be swapped for github actions and a task should be added to run generate-docs and push to github docs.

@OmgImAlexis
Copy link
Contributor Author

I'm happy to cleanup #114 if this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant