Merge pull request #40 from guizmaii/fix_1318

Backport edvin/tornadofx#1319 to Tornado2
edvin · Aug 5, 2021 · 983e868 · 983e868
2 parents 20f3a36 + 04607d4
commit 983e868
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 48 deletions.
diff --git a/src/main/java/tornadofx/Component.kt b/src/main/java/tornadofx/Component.kt
@@ -542,61 +542,53 @@ abstract class UIComponent(viewTitle: String? = "", icon: Node? = null) : Compon
         properties["tornadofx.closeable"] = SimpleBooleanProperty(false)
     }
 
-    private val rootParentChangeListener: ChangeListener<Parent>
-        get() {
-            val key = "tornadofx.rootParentChangeListener"
-            if (properties[key] == null) {
-                properties[key] = ChangeListener<Parent> { _, oldParent, newParent ->
-                    if (modalStage != null) return@ChangeListener
-                    if (newParent == null && oldParent != null && isDocked) callOnUndock()
-                    if (newParent != null && newParent != oldParent && !isDocked) {
-                        callOnDock()
-                        // Call `onTabSelected` if/when we are connected to a Tab and it's selected
-                        // Note that this only works for builder constructed tabpanes
-                        owningTab?.let {
-                            it.selectedProperty()?.onChange { if (it) onTabSelected() }
-                            if (it.isSelected) onTabSelected()
-                        }
-                    }
+    internal val rootParentChangeListener: ChangeListener<Parent> by lazy {
+        ChangeListener<Parent> { _, oldParent, newParent ->
+            if (modalStage != null) return@ChangeListener
+            if (newParent == null && oldParent != null && isDocked) callOnUndock()
+            if (newParent != null && newParent != oldParent && !isDocked) {
+                callOnDock()
+                // Call `onTabSelected` if/when we are connected to a Tab and it's selected
+                // Note that this only works for builder constructed tabpanes
+                owningTab?.let {
+                    it.selectedProperty()?.onChange { if (it) onTabSelected() }
+                    if (it.isSelected) onTabSelected()
                 }
             }
-            return properties[key] as ChangeListener<Parent>
         }
+    }
 
-    private val rootSceneChangeListener: ChangeListener<Scene>
-        get() {
-            val key = "tornadofx.rootSceneChangeListener"
-            if (properties[key] == null) {
-                properties[key] = ChangeListener<Scene> { _, oldParent, newParent ->
-                    if (modalStage != null || root.parent != null) return@ChangeListener
-                    if (newParent == null && oldParent != null && isDocked) callOnUndock()
-                    if (newParent != null && newParent != oldParent && !isDocked) {
-                        // Calls dock or undock when window opens or closes
-                        newParent.windowProperty().onChangeOnce {
-                            it?.showingProperty()?.addListener(rootSceneWindowShowingPropertyChangeListener)
-                        }
-                        callOnDock()
-                    }
+    private val rootSceneChangeListener: ChangeListener<Scene> by lazy {
+        ChangeListener<Scene> { _, oldParent, newParent ->
+            val key = "tornadofx.rootSceneWindowPropertyChangeListener"
+
+            if (modalStage != null || root.parent != null) return@ChangeListener
+            if (newParent == null && oldParent != null && isDocked) {
+                (properties[key] as? ChangeListener<Window>)?.run {
+                    oldParent.windowProperty().removeListener(this)
                 }
+                callOnUndock()
+            }
+            if (newParent != null && newParent != oldParent && !isDocked) {
+                // Calls dock or undock when window opens or closes
+                properties[key] = newParent.windowProperty().onChangeOnce {
+                    it?.showingProperty()?.addListener(rootSceneWindowShowingPropertyChangeListener)
+                }
+                callOnDock()
             }
-            return properties[key] as ChangeListener<Scene>
         }
+    }
 
-    private val rootSceneWindowShowingPropertyChangeListener: ChangeListener<Boolean>
-        get() {
-            val key = "tornadofx.rootSceneWindowShowingPropertyChangeListener"
-            if (properties[key] == null) {
-                properties[key] = ChangeListener<Boolean> { property, oldValue, newValue ->
-                    if (!isInitialized) {
-                        property.removeListener(rootSceneWindowShowingPropertyChangeListener)
-                        return@ChangeListener
-                    }
-                    if (!newValue && isDocked) callOnUndock()
-                    if (newValue && !isDocked) callOnDock()
-                }
+    private val rootSceneWindowShowingPropertyChangeListener: ChangeListener<Boolean> by lazy {
+        ChangeListener<Boolean> { property, oldValue, newValue ->
+            if (!isInitialized) {
+                property.removeListener(rootSceneWindowShowingPropertyChangeListener)
+                return@ChangeListener
             }
-            return properties[key] as ChangeListener<Boolean>
+            if (!newValue && isDocked) callOnUndock()
+            if (newValue && !isDocked) callOnDock()
         }
+    }
 
     internal fun init() {
         if (isInitialized) return

diff --git a/src/main/java/tornadofx/Lib.kt b/src/main/java/tornadofx/Lib.kt
@@ -233,7 +233,7 @@ inline fun <T> ChangeListener(crossinline listener: (observable: ObservableValue
  * Listen for changes to this observable. Optionally only listen x times.
  * The lambda receives the changed value when the change occurs, which may be null,
  */
-fun <T> ObservableValue<T>.onChangeTimes(times: Int, op: (T?) -> Unit) {
+fun <T> ObservableValue<T>.onChangeTimes(times: Int, op: (T?) -> Unit): ChangeListener<T> {
     var counter = 0
     val listener = object : ChangeListener<T> {
         override fun changed(observable: ObservableValue<out T>?, oldValue: T, newValue: T) {
@@ -244,9 +244,10 @@ fun <T> ObservableValue<T>.onChangeTimes(times: Int, op: (T?) -> Unit) {
         }
     }
     addListener(listener)
+    return listener
 }
 
-fun <T> ObservableValue<T>.onChangeOnce(op: (T?) -> Unit) = onChangeTimes(1, op)
+fun <T> ObservableValue<T>.onChangeOnce(op: (T?) -> Unit): ChangeListener<T> = onChangeTimes(1, op)
 
 fun <T> ObservableValue<T>.onChange(op: (T?) -> Unit) = apply { addListener { _, _, newValue -> op(newValue) } }
 fun ObservableBooleanValue.onChange(op: (Boolean) -> Unit) = apply { addListener { _, _, new -> op(new ?: false) } }

diff --git a/src/main/java/tornadofx/Workspace.kt b/src/main/java/tornadofx/Workspace.kt
@@ -312,7 +312,7 @@ open class Workspace(title: String = "Workspace", navigationMode: NavigationMode
             dockedComponent?.also {
                 dockedComponentProperty.value = null
                 if (oldMode == Stack && newMode == Tabs) {
-                    val listener = it.properties["tornadofx.rootParentChangeListener"] as ChangeListener<Parent>
+                    val listener = it.rootParentChangeListener
                     it.root.parentProperty().removeListener(listener)
                     it.callOnUndock()
                     dock(it, true)